home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 964166418

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5944#issuecomment-964166418 https://api.github.com/repos/pydata/xarray/issues/5944 964166418 IC_kwDOAMm_X845eAMS 5821660 2021-11-09T13:47:08Z 2021-11-09T13:47:08Z MEMBER

OK, here are my findings.

There are tests for this in https://github.com/pydata/xarray/blob/main/xarray/tests/test_plugins.py, but they are still using pkg_resources. Because of that, the tests did not capture this issue although we have tests for it.

While fixing the AttributeError the tests finally failed (it was using pkg_resources nomenclature).

With latest #5959 everything should be in place now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1046454702
Powered by Datasette · Queries took 0.784ms · About: xarray-datasette