issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 1021396447 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Display coords' units for slice plots · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
955239781 https://github.com/pydata/xarray/pull/5847#issuecomment-955239781 https://api.github.com/repos/pydata/xarray/issues/5847 IC_kwDOAMm_X844781l dcherian 2448579 2021-10-30T14:06:37Z 2021-10-30T14:06:37Z MEMBER

Thanks @caenrigen 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Display coords' units for slice plots 1021396447
949119077 https://github.com/pydata/xarray/pull/5847#issuecomment-949119077 https://api.github.com/repos/pydata/xarray/issues/5847 IC_kwDOAMm_X844kmhl TomNicholas 35968931 2021-10-22T00:43:16Z 2021-10-22T00:43:59Z MEMBER

That UnitStrippedWarning might be the same one that I apparently forgot to fix in #5561? I need to look more closely...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Display coords' units for slice plots 1021396447
949115762 https://github.com/pydata/xarray/pull/5847#issuecomment-949115762 https://api.github.com/repos/pydata/xarray/issues/5847 IC_kwDOAMm_X844klty TomNicholas 35968931 2021-10-22T00:40:00Z 2021-10-22T00:40:00Z MEMBER

I would appreciate a lot if we keep the scope of this PR to what I have contributed so far, I am running out of bandwidth in the project I am involved and won't be able to add much more to this PR.

Thank you very much for your work so far @caenrigen ! We can take this PR from here :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Display coords' units for slice plots 1021396447
945146242 https://github.com/pydata/xarray/pull/5847#issuecomment-945146242 https://api.github.com/repos/pydata/xarray/issues/5847 IC_kwDOAMm_X844VcmC keewis 14808389 2021-10-17T15:36:28Z 2021-10-17T15:36:28Z MEMBER

but let it xfail for now with a nice explanation

yes, let's wait until the index refactor has progressed a bit more. I'd skip it, though: we know that the test will fail right now, so there's no point in running the test (and it's also what all the other tests do, so it's better to be consistent).

Do the slice plots work with non-dimension coordinates? If so, we should maybe add a test with pint for that, too: units in non-dimension coordinates are not stripped.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Display coords' units for slice plots 1021396447
945070918 https://github.com/pydata/xarray/pull/5847#issuecomment-945070918 https://api.github.com/repos/pydata/xarray/issues/5847 IC_kwDOAMm_X844VKNG Illviljan 14371165 2021-10-17T08:14:35Z 2021-10-17T08:14:35Z MEMBER

I thought a little about the pint issue and for dataarrays you can probably modify the attrs dict around here: https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/core/dataarray.py#L133

But I'm not sure it's worth the effort considering the explicit indexes rework is ongoing, #5692, and that should hopefully allow pint quantities on coords.

I'd suggest adding a pint test anyway, but let it xfail for now with a nice explanation. The TODO comment might get lost in the sea of code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Display coords' units for slice plots 1021396447
945016426 https://github.com/pydata/xarray/pull/5847#issuecomment-945016426 https://api.github.com/repos/pydata/xarray/issues/5847 IC_kwDOAMm_X844U85q Illviljan 14371165 2021-10-16T22:37:44Z 2021-10-16T22:37:44Z MEMBER

That's rather annoying that the pint units are dropped: python arr = xr.DataArray( name="var_a", data=np.array([[1, 2], [3, 4]]), # TODO make coord a Quantity once unit-aware indexes supported coords=dict( a=("a", pint.Quantity(np.array([5, 6]), "s")), b=("b", np.array([7, 8]), {"unit": "s"}), ), dims=("a", "b"), ) C:\Users\J.W\Documents\GitHub\xarray\xarray\core\utils.py:118: UnitStrippedWarning: The unit of the quantity is stripped when downcasting to ndarray. index = pd.Index(np.asarray(array), **kwargs) I think xarray could've at least moved the pint unit string to arr.a.attrs["units"] before downcasting it to ndarrays.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Display coords' units for slice plots 1021396447

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);