home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 945070918

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5847#issuecomment-945070918 https://api.github.com/repos/pydata/xarray/issues/5847 945070918 IC_kwDOAMm_X844VKNG 14371165 2021-10-17T08:14:35Z 2021-10-17T08:14:35Z MEMBER

I thought a little about the pint issue and for dataarrays you can probably modify the attrs dict around here: https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/core/dataarray.py#L133

But I'm not sure it's worth the effort considering the explicit indexes rework is ongoing, #5692, and that should hopefully allow pint quantities on coords.

I'd suggest adding a pint test anyway, but let it xfail for now with a nice explanation. The TODO comment might get lost in the sea of code.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1021396447
Powered by Datasette · Queries took 0.56ms · About: xarray-datasette