issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 101050642 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • Add a --drop-variables flag to xray.open_dataset to exclude certain variables · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
132733172 https://github.com/pydata/xarray/pull/532#issuecomment-132733172 https://api.github.com/repos/pydata/xarray/issues/532 MDEyOklzc3VlQ29tbWVudDEzMjczMzE3Mg== shoyer 1217238 2015-08-19T18:27:33Z 2015-08-19T18:27:33Z MEMBER

OK, merging. Thanks @markelg !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a --drop-variables flag to xray.open_dataset to exclude certain variables 101050642
131976410 https://github.com/pydata/xarray/pull/532#issuecomment-131976410 https://api.github.com/repos/pydata/xarray/issues/532 MDEyOklzc3VlQ29tbWVudDEzMTk3NjQxMA== shoyer 1217238 2015-08-17T22:01:07Z 2015-08-17T22:01:07Z MEMBER

@markelg the test failure was unrelated (see #535 for details). If you merge or rebase on the latest master your tests should be passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a --drop-variables flag to xray.open_dataset to exclude certain variables 101050642
131876765 https://github.com/pydata/xarray/pull/532#issuecomment-131876765 https://api.github.com/repos/pydata/xarray/issues/532 MDEyOklzc3VlQ29tbWVudDEzMTg3Njc2NQ== shoyer 1217238 2015-08-17T16:16:13Z 2015-08-17T16:16:13Z MEMBER

I'll take a look -- something probably changed in one of our upstream dependencies.

On Mon, Aug 17, 2015 at 9:06 AM, Joe Hamman notifications@github.com wrote:

@markelg - The failing test you have is failing for the same reason as #529. I don't think it is related to your PR. @shoyer - Thoughts on what's going on here?

Reply to this email directly or view it on GitHub: https://github.com/xray/xray/pull/532#issuecomment-131874475

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a --drop-variables flag to xray.open_dataset to exclude certain variables 101050642
131191941 https://github.com/pydata/xarray/pull/532#issuecomment-131191941 https://api.github.com/repos/pydata/xarray/issues/532 MDEyOklzc3VlQ29tbWVudDEzMTE5MTk0MQ== shoyer 1217238 2015-08-14T17:41:48Z 2015-08-14T17:41:48Z MEMBER

Looks pretty good to me. However, this does need tests to verify that it works -- see here for some examples: https://github.com/xray/xray/blob/6ed84a04334338533c6773ce4b37d2179130df18/xray/test/test_conventions.py#L460-L493

Also, this needs a note in "What's New" in the docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add a --drop-variables flag to xray.open_dataset to exclude certain variables 101050642

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);