home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 131191941

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/532#issuecomment-131191941 https://api.github.com/repos/pydata/xarray/issues/532 131191941 MDEyOklzc3VlQ29tbWVudDEzMTE5MTk0MQ== 1217238 2015-08-14T17:41:48Z 2015-08-14T17:41:48Z MEMBER

Looks pretty good to me. However, this does need tests to verify that it works -- see here for some examples: https://github.com/xray/xray/blob/6ed84a04334338533c6773ce4b37d2179130df18/xray/test/test_conventions.py#L460-L493

Also, this needs a note in "What's New" in the docs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  101050642
Powered by Datasette · Queries took 0.717ms · About: xarray-datasette