issue_comments

Hi, I have a similar problem. We have model runs starting at 0Z and 12Z so the ones starting at 0Z don't have time (only date) in the unit string, which is not consistent... Is there a workaround?

I have to mention that this test fails probably because of my ultra HD screen.

Cheers

Thanks @spencerahill

py.test seems to be working

Cheers

Thanks @spencerahill:

I have run the flake8 test and modified the whats-new.rst. I think I need more guidance with the tests. I tried using nosetests and get the following exceptions (I am sure I am doing smth wrong here):

``` $ nosetests /Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/matplotlib/init.py:917: UserWarning: axes.hold is deprecated. Please remove it from your matplotlibrc and/or style files. warnings.warn(self.msg_depr_set % key) /Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/matplotlib/rcsetup.py:152: UserWarning: axes.hold is deprecated, will be removed in 3.0 warnings.warn("axes.hold is deprecated, will be removed in 3.0") E ====================================================================== ERROR: Failure: AttributeError (module 'pytest' has no attribute 'config')

Traceback (most recent call last): File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/failure.py", line 39, in runTest raise self.exc_val.with_traceback(self.tb) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/loader.py", line 417, in loadTestsFromName addr.filename, addr.module) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/importer.py", line 47, in importFromPath return self.importFromDir(dir_path, fqname) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/site-packages/nose/importer.py", line 94, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/imp.py", line 244, in load_module return load_package(name, filename) File "/Users/huziy/anaconda/envs/py3.6/lib/python3.6/imp.py", line 216, in load_package return _load(spec) File "<frozen importlib._bootstrap>", line 675, in _load File "<frozen importlib._bootstrap>", line 655, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 678, in exec_module File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed File "/Users/huziy/PythonProjects/xarray/xarray/tests/init.py", line 130, in <module> _SKIP_FLAKY = not pytest.config.getoption("--run-flaky") AttributeError: module 'pytest' has no attribute 'config'

Ran 1 test in 0.582s

FAILED (errors=1) ```

Cheers

Thanks @shoyer: Is there a how to contribute guide? I basically look for how to write a test and run test to check if my adding this option did not break anything...

Cheers

This seems to be working, and no deprecation warning... (But probably I have to sort paths...)

```python In [8]: ds = xarray.concat([xarray.open_dataset(p, chunks={"time": 100}) for p in paths], data_vars="minimal", dim="time")

In [9]: ds Out[9]: <xarray.Dataset> Dimensions: (time: 13505, x: 782, y: 808) Coordinates: * x (x) float64 -4.556e+06 -4.546e+06 -4.536e+06 ... * y (y) float64 4.98e+06 4.97e+06 4.96e+06 4.95e+06 ... * time (time) datetime64[ns] 1993-01-01T12:00:09.140797440 ... Data variables: lon (y, x) float64 156.5 156.5 156.6 156.6 156.7 ... lat (y, x) float64 58.55 58.64 58.72 58.81 58.9 ... lambert_conformal_conic int16 -32767 tmin (time, y, x) float64 nan nan nan nan nan nan ...

In [10]: lon = ds["lon"]

In [11]: lon.ndim Out[11]: 2 ``` Cheers

Thanks @spencerahill : You are right, but the error message won't change, since the data_vars keyword is not known, and I am not able to change the dataset's attribute data_vars. I think I have to use concat explicitly...

Cheers

Hi @shoyer:

where is this data_vars='minimal' set? or maybe I am using a wrong version of xarray? Here is what I get

```python

In [10]: ds = xarray.open_mfdataset("/snow3/huziy/Daymet_daily_derivatives/daymet_spatial_agg_tmin_10x10/daymet_v3_tmin_*.nc4", data_vars="minimum")

TypeError Traceback (most recent call last) <ipython-input-10-ba844206f74a> in <module>() ----> 1 ds = xarray.open_mfdataset("/snow3/huziy/Daymet_daily_derivatives/daymet_spatial_agg_tmin_10x10/daymet_v3_tmin_*.nc4", data_vars="minimum")

/snow3/huziy/Python/python_builds/anaconda3/envs/py3.6-a3/lib/python3.6/site-packages/xarray/backends/api.py in open_mfdataset(paths, chunks, concat_dim, compat, preprocess, engine, lock, **kwargs) 503 paths = sorted(glob(paths)) 504 else: --> 505 paths = [str(p) if isinstance(p, path_type) else p for p in paths] 506 507 if not paths:

/snow3/huziy/Python/python_builds/anaconda3/envs/py3.6-a3/lib/python3.6/site-packages/xarray/backends/api.py in <listcomp>(.0) 503 paths = sorted(glob(paths)) 504 else: --> 505 paths = [str(p) if isinstance(p, path_type) else p for p in paths] 506 507 if not paths:

TypeError: open_dataset() got an unexpected keyword argument 'data_vars'

In [11]: ds = xarray.open_mfdataset("/snow3/huziy/Daymet_daily_derivatives/daymet_spatial_agg_tmin_10x10/daymet_v3_tmin_*.nc4")

In [12]: ds.data_vars = "minimum"

AttributeError Traceback (most recent call last) <ipython-input-12-9026b067946d> in <module>() ----> 1 ds.data_vars = "minimum"

/snow3/huziy/Python/python_builds/anaconda3/envs/py3.6-a3/lib/python3.6/site-packages/xarray/core/common.py in setattr(self, name, value) 180 raise AttributeError( 181 "cannot set attribute %r on a %r object. Use setitem " --> 182 "style assignment (e.g., ds['name'] = ...) instead to " 183 "assign variables." % (name, type(self).name)) 184 object.setattr(self, name, value)

AttributeError: can't set attribute

In [13]: ds.data_vars Out[13]: Data variables: tmin (time, y, x) float64 nan nan nan nan nan nan ... lon (time, y, x) float64 156.5 156.5 156.6 156.6 ... lat (time, y, x) float64 58.55 58.64 58.72 58.81 ... lambert_conformal_conic (time) int64 -32767 -32767 -32767 -32767 -32767 ...

In [16]: xarray.version Out[16]: '0.9.6'

``` Cheers

Thanks, I'll try to use the github version.

Cheers

Hi:

Here I have an example that have worked until recently...

https://github.com/guziy/PyNotebooks/blob/master/xarray/test_grouping.ipynb

Of course there is a resample function, but sometimes you want grouping...

Are there any plans to add a function as a key to the groupby function?

Cheers

Hi @shoyer:

Does a2.resample("D", "time") work in your second example?

with a2.resample("D", "time") I get the following exception:

ValueError: 'time' not found in array dimensions ('t',)

but I think this is working as intended -- if you only supply the name of a dimension with integer labels, xarray has no way to know how what times to use for resampling.

I am not sure how it is done now or whether it is possible to implement, but I feel like it searches for the coordinate with the same name as the supplied dimension. Probably searching for a coordinate containing only the dimension specified in resample could do the trick.

Maybe there is a better way to do what I am trying to do?: I needed it to calculate daily means. But I have a hole in my data in the middle of the year and resample is masking this hole, by adding masked fields. So I've done it with groupby as follows, but it seems there should be an easier way to achieve this:

python day_dates = [datetime(d.year, d.month, d.day) for d in pd.to_datetime(snfl.coords["t"].values)] day_dates = DataArray(day_dates, name="time", dims="t") snfl = snfl.groupby(day_dates).mean(dim="t")