issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR" and user = 5384661 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • maciekswat · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
222017597 https://github.com/pydata/xarray/pull/837#issuecomment-222017597 https://api.github.com/repos/pydata/xarray/issues/837 MDEyOklzc3VlQ29tbWVudDIyMjAxNzU5Nw== maciekswat 5384661 2016-05-26T22:53:00Z 2016-05-26T22:53:00Z CONTRIBUTOR

Added bugfix entry in what's new

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed a bug that showed when trying to establish equivalence of two a… 151483622
222016181 https://github.com/pydata/xarray/issues/861#issuecomment-222016181 https://api.github.com/repos/pydata/xarray/issues/861 MDEyOklzc3VlQ29tbWVudDIyMjAxNjE4MQ== maciekswat 5384661 2016-05-26T22:44:30Z 2016-05-26T22:44:30Z CONTRIBUTOR

Yes this is #837 - so feel frre to close the issue . I will add entries to "what's new".If there is anything else needed, please let me know

On 5/25/16 7:27 PM, Stephan Hoyer wrote:

@maciekswat https://github.com/maciekswat This is your PR, yes? #837 https://github.com/pydata/xarray/pull/837

we are almost ready to merge -- just a few quick changes needed.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/issues/861#issuecomment-221737294

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bug in arithmetic operations on DataArray objects whose dimensions are numpy structured arrays or recarrays 156857895
216556267 https://github.com/pydata/xarray/pull/837#issuecomment-216556267 https://api.github.com/repos/pydata/xarray/issues/837 MDEyOklzc3VlQ29tbWVudDIxNjU1NjI2Nw== maciekswat 5384661 2016-05-03T15:00:17Z 2016-05-03T15:00:17Z CONTRIBUTOR

Added a comment explaining why we need to catch typeError in array_equiv

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed a bug that showed when trying to establish equivalence of two a… 151483622
216338679 https://github.com/pydata/xarray/pull/837#issuecomment-216338679 https://api.github.com/repos/pydata/xarray/issues/837 MDEyOklzc3VlQ29tbWVudDIxNjMzODY3OQ== maciekswat 5384661 2016-05-02T19:35:04Z 2016-05-02T19:35:04Z CONTRIBUTOR

I simplified the test - please feel free to do further edits, also added doc string explaining what the test checks for - essentially it checks if DataArray subtraction behaves correctly when dimension is a structured numpy array. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed a bug that showed when trying to establish equivalence of two a… 151483622
216313208 https://github.com/pydata/xarray/pull/837#issuecomment-216313208 https://api.github.com/repos/pydata/xarray/issues/837 MDEyOklzc3VlQ29tbWVudDIxNjMxMzIwOA== maciekswat 5384661 2016-05-02T18:06:38Z 2016-05-02T18:06:38Z CONTRIBUTOR

just fixed the formatting according to PEP8 guidelines

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed a bug that showed when trying to establish equivalence of two a… 151483622
216307904 https://github.com/pydata/xarray/pull/837#issuecomment-216307904 https://api.github.com/repos/pydata/xarray/issues/837 MDEyOklzc3VlQ29tbWVudDIxNjMwNzkwNA== maciekswat 5384661 2016-05-02T17:48:02Z 2016-05-02T17:48:02Z CONTRIBUTOR

I have rewrote array_equiv fcn from ops.py to use single comparison (the one which tests from null is inside try/except clause). Also added test case to test_DataArray.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed a bug that showed when trying to establish equivalence of two a… 151483622

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);