issue_comments

Table actions

7 rows where author_association = "CONTRIBUTOR" and issue = 957131705 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • recent versions of sparse and dask seem to be incompatible with our tests · 7 ✖

author_association 1

  • CONTRIBUTOR · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
909333730 https://github.com/pydata/xarray/issues/5654#issuecomment-909333730 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842M1Ti jrbourbeau 11656932 2021-08-31T15:17:44Z 2021-08-31T15:17:44Z CONTRIBUTOR

This should be closed via https://github.com/pydata/xarray/pull/5751. Again, thanks all for your efforts! 

{
    "total_count": 4,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705
906689573 https://github.com/pydata/xarray/issues/5654#issuecomment-906689573 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842Cvwl jrbourbeau 11656932 2021-08-26T19:38:37Z 2021-08-26T19:38:37Z CONTRIBUTOR

Thanks for hunting all this down @crusaderky, I'm currently grokking it. Also cc @hameerabbasi for visibility 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705
906631637 https://github.com/pydata/xarray/issues/5654#issuecomment-906631637 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842ChnV jrbourbeau 11656932 2021-08-26T18:12:01Z 2021-08-26T18:12:01Z CONTRIBUTOR

Hrm, looking at the API docs for sparse.zeros_like, it appears to support shape=

```python In [1]: import sparse

In [2]: sparse.version Out[2]: '0.12.0'

In [3]: import numpy as np

In [4]: x = np.arange(6)

In [5]: y = sparse.zeros_like(x, shape=(3, 2))

In [6]: y Out[6]: <COO: shape=(3, 2), dtype=int64, nnz=0, fill_value=0>

In [7]: y.todense() Out[7]: array([[0, 0], [0, 0], [0, 0]]) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705
905592839 https://github.com/pydata/xarray/issues/5654#issuecomment-905592839 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X841-kAH jrbourbeau 11656932 2021-08-25T15:10:10Z 2021-08-25T15:10:10Z CONTRIBUTOR

Also cc @crusaderky if you get a chance to look into this 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705
903022152 https://github.com/pydata/xarray/issues/5654#issuecomment-903022152 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X8410wZI jrbourbeau 11656932 2021-08-21T00:30:11Z 2021-08-21T00:30:11Z CONTRIBUTOR

Good point. CI is currently pulling in the latest sparse=0.12.0 release (which is also what I'm running locally).

It also appears there were some ordering concerns related to https://github.com/dask/dask/issues/5259 when test_chunk was added (xref https://github.com/pydata/xarray/pull/3202#discussion_r313098400) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705
903005031 https://github.com/pydata/xarray/issues/5654#issuecomment-903005031 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X8410sNn jrbourbeau 11656932 2021-08-20T23:22:35Z 2021-08-20T23:23:28Z CONTRIBUTOR

Ah, that's a good point @keewis. Stepping back a bit, my current situation locally is I'm able to reproduce the xarray/tests/test_sparse.py::test_chunk failure with:

Rolling dask back to the 2021.7.2 release, but keeping everything else the same, test_chunk passes. After running git bisect between the latest dask commit and the 2021.7.2 release, https://github.com/dask/dask/pull/7939 is the point where test_chunk started failing (cc @jakirkham for visibility). I'll try to dig in a bit more to see if I can find the root cause of the failure

EDIT: I should note that the test_chunk failure has a similar traceback to https://github.com/dask/dask/issues/5259

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705
899855458 https://github.com/pydata/xarray/issues/5654#issuecomment-899855458 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X841orRi jrbourbeau 11656932 2021-08-16T22:20:00Z 2021-08-16T22:35:59Z CONTRIBUTOR

Thanks for the ping @dcherian. Running against Dask's git history, https://github.com/dask/dask/pull/7939 is the place where xarray/tests/test_sparse.py::test_chunk started failing. We probably dropped some relevant compatibility code when we stopped supporting NumPy 1.17 and pandas 0.25.

Since xarray has a clearly defined policy for minimum dependencies, would dropping NumPy 1.17 and pandas 0.25 be an acceptable solution here? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   recent versions of sparse and dask seem to be incompatible with our tests 957131705

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);