issue_comments

Table actions

5 rows where author_association = "CONTRIBUTOR" and issue = 954574705 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Fix performance bug from cftime import · 5 ✖

author_association 1

  • CONTRIBUTOR · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
888418180 https://github.com/pydata/xarray/pull/5640#issuecomment-888418180 https://api.github.com/repos/pydata/xarray/issues/5640 IC_kwDOAMm_X8409C-E github-actions[bot] 41898282 2021-07-28T15:46:37Z 2021-09-29T16:34:00Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   57m 49s :stopwatch: ±0s 16 227 tests ±0  14 492 :heavy_check_mark: ±0  1 735 :zzz: ±0  0 :x: ±0  90 558 runs  ±0  82 384 :heavy_check_mark: ±0  8 174 :zzz: ±0  0 :x: ±0 

Results for commit 43409090. ± Comparison against base commit 43409090.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix performance bug from cftime import 954574705
917924524 https://github.com/pydata/xarray/pull/5640#issuecomment-917924524 https://api.github.com/repos/pydata/xarray/issues/5640 IC_kwDOAMm_X842tmqs lusewell 3801015 2021-09-13T07:39:22Z 2021-09-13T07:39:22Z CONTRIBUTOR

Fixed other usages and added to whats-new.rst

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix performance bug from cftime import 954574705
916837170 https://github.com/pydata/xarray/pull/5640#issuecomment-916837170 https://api.github.com/repos/pydata/xarray/issues/5640 IC_kwDOAMm_X842pdMy lusewell 3801015 2021-09-10T11:36:35Z 2021-09-10T11:36:35Z CONTRIBUTOR

@spencerkclark

RE perfomance.

Its only a performance issue to attempt to import cftime repeatedly. Having it fail once in the top level import is not a big problem. The issue comes when it does it thousands of times every time you try and .sel or .isel, which then adds up to a huge performance hit. Given xarray takes a while to import anyway, the marginal cost of search ing the full pythonpath 3 times in import is minimal - only an issue when done repeatedly.

I've fixed this for some other cases I've found that were causing me slowness - would like me to changeanythinng else before this can be merged?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix performance bug from cftime import 954574705
916834298 https://github.com/pydata/xarray/pull/5640#issuecomment-916834298 https://api.github.com/repos/pydata/xarray/issues/5640 IC_kwDOAMm_X842pcf6 lusewell 3801015 2021-09-10T11:30:47Z 2021-09-10T11:30:47Z CONTRIBUTOR

So i've found another instance of this which causes a performance issue - this one with groupby.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix performance bug from cftime import 954574705
888122071 https://github.com/pydata/xarray/pull/5640#issuecomment-888122071 https://api.github.com/repos/pydata/xarray/issues/5640 IC_kwDOAMm_X84076rX lusewell 3801015 2021-07-28T08:32:44Z 2021-07-28T08:32:44Z CONTRIBUTOR

I'd also like to append this to tag 14.1 and make tag 14.2 if possible - would this be ok?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix performance bug from cftime import 954574705

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);