issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and issue = 879033384 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • DataArray.clip() no longer supports the out argument · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
856340566 https://github.com/pydata/xarray/issues/5278#issuecomment-856340566 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDg1NjM0MDU2Ng== seth-p 7441788 2021-06-08T00:02:48Z 2021-06-08T00:04:28Z CONTRIBUTOR

almost no attention is paid to minimizing memory consumption (whether through in-place operations, or more generally minimizing temporary memory usage).

I think we'd be open to fixing this when it doesn't compromise readability. Can you open a new issue with some particularly bad examples?

I wouldn't necessarily say that it's particularly bad, but see the discussion following https://github.com/pydata/xarray/pull/2922#issuecomment-601496897.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384
835597488 https://github.com/pydata/xarray/issues/5278#issuecomment-835597488 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDgzNTU5NzQ4OA== seth-p 7441788 2021-05-09T00:40:08Z 2021-05-09T00:40:08Z CONTRIBUTOR

I'm not familiar at all with the various numpy interfaces, so I can't offer any input implementation-wise. But as a user, being able to do operations in place (via out or otherwise) is extremely useful when dealing with large arrays under memory constraints. In fact my one "philosophical" beef with xarray is that it seems almost no attention is paid to minimizing memory consumption (whether through in-place operations, or more generally minimizing temporary memory usage).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384
835499783 https://github.com/pydata/xarray/issues/5278#issuecomment-835499783 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDgzNTQ5OTc4Mw== raybellwaves 17162724 2021-05-08T20:26:51Z 2021-05-08T20:26:51Z CONTRIBUTOR

FWIW. This showed up in xskillscore as we were doing np.clip(xarray object, min, min). We updated the code to do xarray object.clip(min, max) which we probably should have been doing in the first place (https://github.com/xarray-contrib/xskillscore/pull/309#issue-634256273)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384
834629871 https://github.com/pydata/xarray/issues/5278#issuecomment-834629871 https://api.github.com/repos/pydata/xarray/issues/5278 MDEyOklzc3VlQ29tbWVudDgzNDYyOTg3MQ== seth-p 7441788 2021-05-07T17:11:01Z 2021-05-07T17:11:14Z CONTRIBUTOR

What is the case for having out kwargs?

It lets you reuse memory you already have. In particular for a simple operation like clip, you can do it in-place: da.clip(..., out=da.values). Very useful if you deal with lots of data and memory is a concern.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.clip() no longer supports the out argument 879033384

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);