issue_comments

Table actions

5 rows where author_association = "CONTRIBUTOR" and issue = 857947050 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Calendar utilities · 5 ✖

author_association 1

  • CONTRIBUTOR · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
953076586 https://github.com/pydata/xarray/issues/5155#issuecomment-953076586 https://api.github.com/repos/pydata/xarray/issues/5155 IC_kwDOAMm_X844zstq aulemahal 20629530 2021-10-27T16:06:01Z 2021-10-27T16:06:15Z CONTRIBUTOR

I agree that it kinda crowds the xarray API. My first idea was to implement these calendar utilities in cf-xarray, but I was redirected here. Seems to me that if that move is made, it's the most logical place for all CF[time] related things.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Calendar utilities 857947050
824379535 https://github.com/pydata/xarray/issues/5155#issuecomment-824379535 https://api.github.com/repos/pydata/xarray/issues/5155 MDEyOklzc3VlQ29tbWVudDgyNDM3OTUzNQ== aulemahal 20629530 2021-04-21T21:46:42Z 2021-04-21T21:46:42Z CONTRIBUTOR

Edited the comment above as I realized that numpy /pandas / xarray use nanoseconds by default, so the earliest date possible is 1677-09-21 00:12:43.145225. Thus, I suggest we return "standard" as the calendar of numpy-backed datetime indexes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Calendar utilities 857947050
824373780 https://github.com/pydata/xarray/issues/5155#issuecomment-824373780 https://api.github.com/repos/pydata/xarray/issues/5155 MDEyOklzc3VlQ29tbWVudDgyNDM3Mzc4MA== aulemahal 20629530 2021-04-21T21:37:59Z 2021-04-21T21:44:58Z CONTRIBUTOR

Cool! I started a branch, will push a PR soon.

I understand the "default" issue and using use_cftime=None makes sense to me!

~For dt.calendar and date_range, there remains the question on how we name numpy's calendar: Python uses what CF conventions call proleptic_gregorian, but the default and most common calendar we see and use is CF's "standard". May be users would expect "standard"? A solution would be to check if the earliest value in the array is before 1582-10-15. If yes, return "proleptic_gregorian", if not, return "standard".~

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Calendar utilities 857947050
819570900 https://github.com/pydata/xarray/issues/5155#issuecomment-819570900 https://api.github.com/repos/pydata/xarray/issues/5155 MDEyOklzc3VlQ29tbWVudDgxOTU3MDkwMA== aulemahal 20629530 2021-04-14T14:40:14Z 2021-04-14T14:40:14Z CONTRIBUTOR

@aaronspring Oh, I didn't think of that trick for 1, thanks! But again, this fails with numpy-backed time coordinates. With the definition of a "default" calendar, there could be a more general way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Calendar utilities 857947050
819566971 https://github.com/pydata/xarray/issues/5155#issuecomment-819566971 https://api.github.com/repos/pydata/xarray/issues/5155 MDEyOklzc3VlQ29tbWVudDgxOTU2Njk3MQ== aaronspring 12237157 2021-04-14T14:34:55Z 2021-04-14T14:34:55Z CONTRIBUTOR
  1. exists as ds.time.to_index().calendar
  2. would like to use
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Calendar utilities 857947050

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);