issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR" and issue = 856900805 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Handling of non-string dimension names · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
818821420 https://github.com/pydata/xarray/issues/5148#issuecomment-818821420 https://api.github.com/repos/pydata/xarray/issues/5148 MDEyOklzc3VlQ29tbWVudDgxODgyMTQyMA== bcbnz 367900 2021-04-13T15:20:50Z 2021-04-13T15:29:54Z CONTRIBUTOR

I've changed the title.

I think improving the error message is the way to go.

Agreed. ~~Just playing with it, the attributes also need to be strings for netCDF (I'm not familiar with the other backends) so an equivalent error message should be added for them.~~ There is already a good error message for attributes, at least for netCDF, I wasn't looking at it properly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handling of non-string dimension names 856900805
818800250 https://github.com/pydata/xarray/issues/5148#issuecomment-818800250 https://api.github.com/repos/pydata/xarray/issues/5148 MDEyOklzc3VlQ29tbWVudDgxODgwMDI1MA== bcbnz 367900 2021-04-13T14:53:14Z 2021-04-13T14:55:03Z CONTRIBUTOR

This is also something that the backends will need to consider:

```python traceback

xr.DataArray(np.ones(5)).rename(dim_0=1).to_netcdf("/tmp/test.nc") ... /usr/lib/python3.9/site-packages/xarray/backends/netCDF4_.py in set_dimension(self, name, length, is_unlimited) 439 def set_dimension(self, name, length, is_unlimited=False): 440 dim_length = length if not is_unlimited else None --> 441 self.ds.createDimension(name, size=dim_length) 442 443 def set_attribute(self, key, value):

src/netCDF4/_netCDF4.pyx in netCDF4._netCDF4.Dataset.createDimension()

src/netCDF4/_netCDF4.pyx in netCDF4._netCDF4.Dimension.init()

TypeError: expected bytes, int found ` I guess they could either convert to string (which will result in a different array when loaded) or a better error message (netCDF files only support strings for dimension names`` or similar).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handling of non-string dimension names 856900805
818800770 https://github.com/pydata/xarray/issues/5148#issuecomment-818800770 https://api.github.com/repos/pydata/xarray/issues/5148 MDEyOklzc3VlQ29tbWVudDgxODgwMDc3MA== bcbnz 367900 2021-04-13T14:53:55Z 2021-04-13T14:53:55Z CONTRIBUTOR

Should I change the title here to be more general or would you prefer to close this and continue discussion in the other issue you linked?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handling of non-string dimension names 856900805

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);