issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR" and issue = 668717850 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • bool(Dataset(False)) is True · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
669204458 https://github.com/pydata/xarray/issues/4290#issuecomment-669204458 https://api.github.com/repos/pydata/xarray/issues/4290 MDEyOklzc3VlQ29tbWVudDY2OTIwNDQ1OA== aaronspring 12237157 2020-08-05T13:48:55Z 2020-08-05T13:48:55Z CONTRIBUTOR

For those who think bool(xr.Dataset(dict(x=False))) should evaluate to False, what do you think dict(x=False) should evaluate to?

good point

IIUC, this is somewhat of an edge case — it's only possible to coerce DataArray to bool when there's exactly one element. (Not that we shouldn't resolve)

I now understand the underlying problem better with your comments. My expectations were too naive about it. I cannot evaluate the consequences of changing this. I close this issue and hopefully users having this problem in the future will find this issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bool(Dataset(False)) is True 668717850
666380379 https://github.com/pydata/xarray/issues/4290#issuecomment-666380379 https://api.github.com/repos/pydata/xarray/issues/4290 MDEyOklzc3VlQ29tbWVudDY2NjM4MDM3OQ== aaronspring 12237157 2020-07-30T13:56:30Z 2020-07-30T14:13:24Z CONTRIBUTOR

currently

python if (xrobject > 10).any(): raise ValueError('blabla') depends on whether xrobject is xr.DataArray or xr.Dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bool(Dataset(False)) is True 668717850
666370889 https://github.com/pydata/xarray/issues/4290#issuecomment-666370889 https://api.github.com/repos/pydata/xarray/issues/4290 MDEyOklzc3VlQ29tbWVudDY2NjM3MDg4OQ== aaronspring 12237157 2020-07-30T13:39:55Z 2020-07-30T13:39:55Z CONTRIBUTOR

thanks for the explanation. but from a naive user perspective,

python bool(xr.DataArray(False).to_dataset(name='var')) # False bool(xr.DataArray(True).to_dataset(name='var')) # True bool(xr.DataArray(False)) # False bool(xr.DataArray(True)) # True would be nice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bool(Dataset(False)) is True 668717850

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);