issue_comments

Table actions

25 rows where author_association = "CONTRIBUTOR" and issue = 510294810 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Html repr · 25 ✖

author_association 1

  • CONTRIBUTOR · 25 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
546089446 https://github.com/pydata/xarray/pull/3425#issuecomment-546089446 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjA4OTQ0Ng== jsignell 4806877 2019-10-24T20:29:22Z 2019-10-24T20:29:22Z CONTRIBUTOR

Besides variable names, we probably need to somehow handle overflow for variables that have a long list of dimension labels.

These are handled in the same way as long variable names, they truncate with an ellipsis and then expand on hover.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
546088350 https://github.com/pydata/xarray/pull/3425#issuecomment-546088350 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjA4ODM1MA== jsignell 4806877 2019-10-24T20:26:17Z 2019-10-24T20:26:17Z CONTRIBUTOR

I opened a PR and included a small test. It can probably go in while we work on a more complete testing infrastructure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
546082146 https://github.com/pydata/xarray/pull/3425#issuecomment-546082146 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjA4MjE0Ng== jsignell 4806877 2019-10-24T20:09:44Z 2019-10-24T20:09:44Z CONTRIBUTOR

I looks like we'll need to fix a couple of issues (the channel coordinate looks weird), but maybe it is not related to the front-end.

I am opening a PR. I didn't escape dtypes and this dtype is <U5 which html does terribly with

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
546004493 https://github.com/pydata/xarray/pull/3425#issuecomment-546004493 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NjAwNDQ5Mw== jsignell 4806877 2019-10-24T16:44:55Z 2019-10-24T16:44:55Z CONTRIBUTOR

It isn't too hard to get it working with dark theme, but requires slight tweaks to the colors to align with those provided as vars by jlab. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545986160 https://github.com/pydata/xarray/pull/3425#issuecomment-545986160 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk4NjE2MA== jsignell 4806877 2019-10-24T15:59:31Z 2019-10-24T15:59:31Z CONTRIBUTOR

Ok I think it's fixed now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545979852 https://github.com/pydata/xarray/pull/3425#issuecomment-545979852 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk3OTg1Mg== jsignell 4806877 2019-10-24T15:45:19Z 2019-10-24T15:45:19Z CONTRIBUTOR

I'm on 1.1.4 in chrome. Let me check firefox

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545978093 https://github.com/pydata/xarray/pull/3425#issuecomment-545978093 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk3ODA5Mw== jsignell 4806877 2019-10-24T15:41:17Z 2019-10-24T15:41:17Z CONTRIBUTOR

Yeah to make it work with the dark theme we'll need to use the jlab css variables I imagine. I think it can be merged with dark mode not supported.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545977030 https://github.com/pydata/xarray/pull/3425#issuecomment-545977030 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk3NzAzMA== jsignell 4806877 2019-10-24T15:38:48Z 2019-10-24T15:38:48Z CONTRIBUTOR

Fixed the jlab alignment issue. The issue was that jlab has different default css.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545973962 https://github.com/pydata/xarray/pull/3425#issuecomment-545973962 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTk3Mzk2Mg== jsignell 4806877 2019-10-24T15:32:08Z 2019-10-24T15:32:08Z CONTRIBUTOR

I've noticed an issue with the alignment of attributes in jupyterlab (1.1.4) (Firefox 69.0.3):

I'm taking a look at the jlab css. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545928015 https://github.com/pydata/xarray/pull/3425#issuecomment-545928015 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTkyODAxNQ== jsignell 4806877 2019-10-24T13:51:45Z 2019-10-24T13:51:45Z CONTRIBUTOR

@benbovy just to make double sure, you are happy with this new feature being off by default right?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545916227 https://github.com/pydata/xarray/pull/3425#issuecomment-545916227 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTkxNjIyNw== jsignell 4806877 2019-10-24T13:24:45Z 2019-10-24T13:24:45Z CONTRIBUTOR

So maybe one more rebase will do it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545648937 https://github.com/pydata/xarray/pull/3425#issuecomment-545648937 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTY0ODkzNw== jsignell 4806877 2019-10-23T21:43:02Z 2019-10-23T21:43:02Z CONTRIBUTOR

Well, I rebased. Hopefully it'll pass now. I consider this done unless someone wants more docs or more tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545647958 https://github.com/pydata/xarray/pull/3425#issuecomment-545647958 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTY0Nzk1OA== jsignell 4806877 2019-10-23T21:39:52Z 2019-10-23T21:39:52Z CONTRIBUTOR

I am 90% sure this failure is unrelated. Maybe I should rebase now that #3436 has landed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545637867 https://github.com/pydata/xarray/pull/3425#issuecomment-545637867 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTYzNzg2Nw== jsignell 4806877 2019-10-23T21:10:33Z 2019-10-23T21:10:33Z CONTRIBUTOR

Oh. The dask version in ci doesn't have _repr_html_. I'll add a version checker to the test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545605598 https://github.com/pydata/xarray/pull/3425#issuecomment-545605598 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTYwNTU5OA== jsignell 4806877 2019-10-23T19:43:54Z 2019-10-23T19:43:54Z CONTRIBUTOR

Otherwise I think all that is left is adding docs. Also I want to confirm that this should be an experimental feature (off by default). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545597657 https://github.com/pydata/xarray/pull/3425#issuecomment-545597657 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTU5NzY1Nw== jsignell 4806877 2019-10-23T19:23:16Z 2019-10-23T19:23:16Z CONTRIBUTOR

I added some tests. I can add more if anyone has a test case that they want to be sure is covered. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545545019 https://github.com/pydata/xarray/pull/3425#issuecomment-545545019 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTU0NTAxOQ== jsignell 4806877 2019-10-23T17:11:51Z 2019-10-23T17:11:51Z CONTRIBUTOR

Ok I am going to write some tests now. I updated the gist. Do people like the names "classic" and "html" for the display_style options? Another option would be "classic" and "rich".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545542947 https://github.com/pydata/xarray/pull/3425#issuecomment-545542947 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTU0Mjk0Nw== jsignell 4806877 2019-10-23T17:07:33Z 2019-10-23T17:08:56Z CONTRIBUTOR

~~Oh I was looking at bytes not len.~~ I didn't have .encode('utf8')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545539785 https://github.com/pydata/xarray/pull/3425#issuecomment-545539785 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTUzOTc4NQ== jsignell 4806877 2019-10-23T16:59:38Z 2019-10-23T16:59:38Z CONTRIBUTOR

I'm still worried about size, but minifying the css and even minifying the html did not make a big difference. It looks like the html_repr for rasm is 38kb .

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545177297 https://github.com/pydata/xarray/pull/3425#issuecomment-545177297 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTE3NzI5Nw== jsignell 4806877 2019-10-22T22:08:49Z 2019-10-22T22:08:49Z CONTRIBUTOR

Ok I think I've addressed all the comments. I just updated the gist with the latest output. Tomorrow I'll start adding tests. The css is now ~300 lines and it gets injected everytime the dataset is rendered. I'm not sure if that is considered too long and if it is I don't quite know what to do about it. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
545074728 https://github.com/pydata/xarray/pull/3425#issuecomment-545074728 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NTA3NDcyOA== jsignell 4806877 2019-10-22T17:42:03Z 2019-10-22T17:42:03Z CONTRIBUTOR

Is there ever a situation in which dimensions would be expandable? It seems like it is hard-coded to collapsed.

I am trying to generalize the css to reduce the length.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
544980677 https://github.com/pydata/xarray/pull/3425#issuecomment-544980677 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NDk4MDY3Nw== jsignell 4806877 2019-10-22T14:08:00Z 2019-10-22T14:08:00Z CONTRIBUTOR

I just updated the gist with these changes: - got rid of alternating data colors in preview - fixed icon alignment in row, and rest of data in row - got rid of some not-useful spans - changed from underline to bold for index coords

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
544957163 https://github.com/pydata/xarray/pull/3425#issuecomment-544957163 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NDk1NzE2Mw== jsignell 4806877 2019-10-22T13:17:28Z 2019-10-22T13:17:28Z CONTRIBUTOR

Yeah the data preview is also shifted vertically. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
544768411 https://github.com/pydata/xarray/pull/3425#issuecomment-544768411 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NDc2ODQxMQ== jsignell 4806877 2019-10-22T01:01:22Z 2019-10-22T01:01:22Z CONTRIBUTOR

Yeah I agree that is a strange part of the original PR. The version in the fiddle doesn't do that, so I'd really like to hear back from @benbovy about whether the fiddle css is more uptodate.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810
544731859 https://github.com/pydata/xarray/pull/3425#issuecomment-544731859 https://api.github.com/repos/pydata/xarray/issues/3425 MDEyOklzc3VlQ29tbWVudDU0NDczMTg1OQ== jsignell 4806877 2019-10-21T22:18:14Z 2019-10-21T22:18:14Z CONTRIBUTOR

I don't really like how the attrs look without the alignment of keys and values. I will think about how to make that more legible

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Html repr 510294810

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);