issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR", issue = 492866552 and user = 1941408 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • stefraynaud · 2 ✖

issue 1

  • interpolate_na: Add max_gap support. · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
531674432 https://github.com/pydata/xarray/pull/3302#issuecomment-531674432 https://api.github.com/repos/pydata/xarray/issues/3302 MDEyOklzc3VlQ29tbWVudDUzMTY3NDQzMg== stefraynaud 1941408 2019-09-16T07:50:26Z 2019-09-16T07:50:26Z CONTRIBUTOR

Thanks @stefraynaud . I'm having trouble figuring out defining the length of a gap in the irregular coordinate case.

e.g.

da4 = xr.DataArray([np.nan, np.nan, np.nan, 1, np.nan, np.nan, 4, np.nan, np.nan], dims=["y"], coords={"y": [0, 2, 5, 6, 7, 8, 10, 12, 14]})

<xarray.DataArray (y: 9)> array([nan, nan, nan, 1., nan, nan, 4., nan, nan]) Coordinates: * y (y) int64 0 2 5 6 7 8 10 12 14

What is the length of these three gaps given that xarray doesn't have any understanding of grids?

@dcherian In your example, as said @max-sixty, the middle gap has a length of 10-6=4. The length gaps at the edges cannot be computed but it doesn't matter, and the algo should work as when simply counting the nans.

I'll have a look the code, maybe for a new PR after this one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   interpolate_na: Add max_gap support. 492866552
531248632 https://github.com/pydata/xarray/pull/3302#issuecomment-531248632 https://api.github.com/repos/pydata/xarray/issues/3302 MDEyOklzc3VlQ29tbWVudDUzMTI0ODYzMg== stefraynaud 1941408 2019-09-13T14:00:30Z 2019-09-13T14:00:30Z CONTRIBUTOR

Nice feature. How about adding the support max gaps expressed in physical units, since coordinates may be irregular?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   interpolate_na: Add max_gap support. 492866552

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);