issue_comments

Table actions

9 rows where author_association = "CONTRIBUTOR" and issue = 482543307 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Use pytorch as backend for xarrays · 9 ✖

author_association 1

  • CONTRIBUTOR · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1190382681 https://github.com/pydata/xarray/issues/3232#issuecomment-1190382681 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G88xZ hsharrison 4441865 2022-07-20T14:48:15Z 2022-07-20T14:48:15Z CONTRIBUTOR

Makes sense, then I'll wait for https://github.com/pytorch/pytorch/issues/58743 to try it.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
1190162973 https://github.com/pydata/xarray/issues/3232#issuecomment-1190162973 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G8HId tomwhite 85085 2022-07-20T11:35:03Z 2022-07-20T11:35:03Z CONTRIBUTOR

I think it can't be tested with pytorch until they compete pytorch/pytorch#58743, right?

It needs __array_namespace__ to be defined to activate the new code path.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
1190068100 https://github.com/pydata/xarray/issues/3232#issuecomment-1190068100 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G7v-E hsharrison 4441865 2022-07-20T09:50:59Z 2022-07-20T09:50:59Z CONTRIBUTOR

Nice that it's so simple. I think it can't be tested with pytorch until they compete https://github.com/pytorch/pytorch/issues/58743, right?

Or we should just try passing torch.tensor into xarray directly?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
1189941650 https://github.com/pydata/xarray/issues/3232#issuecomment-1189941650 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G7RGS tomwhite 85085 2022-07-20T07:45:39Z 2022-07-20T07:45:39Z CONTRIBUTOR

Hi @hsharrison - thanks for offering to do some testing. Here's a little demo script that you could try, by switching numpy.array_api to pytorch: https://github.com/tomwhite/xarray/commit/929812a12818ffaa1187eb860c9b61e3fc03973c

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
1189938517 https://github.com/pydata/xarray/issues/3232#issuecomment-1189938517 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G7QVV hsharrison 4441865 2022-07-20T07:42:05Z 2022-07-20T07:42:05Z CONTRIBUTOR

Glad to see progress on this!! 👏

Just curious though, seeing this comment in the PR:

Note: I haven't actually tested this with pytorch (which is the motivating example for https://github.com/pydata/xarray/issues/3232).

Are we sure this closes the issue? And, how can we try it out? Even lacking docs, a comment explaining how to set it up would be great, and I can do some testing on my end. I understand that it's an experimental feature.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
1187007032 https://github.com/pydata/xarray/issues/3232#issuecomment-1187007032 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85GwEo4 tomwhite 85085 2022-07-18T10:04:29Z 2022-07-18T10:04:29Z CONTRIBUTOR

Opened #6804

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
1182978725 https://github.com/pydata/xarray/issues/3232#issuecomment-1182978725 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85GgtKl tomwhite 85085 2022-07-13T09:18:51Z 2022-07-13T09:18:51Z CONTRIBUTOR

I started having a look at making xarray work with the array API here: https://github.com/tomwhite/xarray/commit/c72a1c4a4c52152bdab83f60f35615de28e8be7f. Some basic operations work (preserving the underlying array): https://github.com/tomwhite/xarray/commit/929812a12818ffaa1187eb860c9b61e3fc03973c. If there's interest, I'd be happy to turn this into a PR with some tests.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
656627686 https://github.com/pydata/xarray/issues/3232#issuecomment-656627686 https://api.github.com/repos/pydata/xarray/issues/3232 MDEyOklzc3VlQ29tbWVudDY1NjYyNzY4Ng== jacobtomlinson 1610850 2020-07-10T11:30:36Z 2020-07-10T11:30:36Z CONTRIBUTOR

@fjanoos I'm afraid I don't. In RAPIDS we support cupy as our GPU array implementation. So this request has come from the desire to make xarray compatible with the RAPIDS suite of tools.

We commonly see folks using cupy to switch straight over to a tool like pytorch using DLPack. https://docs-cupy.chainer.org/en/stable/reference/interoperability.html#dlpack

But I don't really see #4212 as an effort to make cupy the GPU backend for xarray. I see it as adding support for another backend to xarray. The more the merrier!

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307
656178897 https://github.com/pydata/xarray/issues/3232#issuecomment-656178897 https://api.github.com/repos/pydata/xarray/issues/3232 MDEyOklzc3VlQ29tbWVudDY1NjE3ODg5Nw== jacobtomlinson 1610850 2020-07-09T14:58:40Z 2020-07-09T14:58:40Z CONTRIBUTOR

@andersy005 I'm about to start working actively on cupy support in xarray. Would be great to get some of your input.

Cupy requests that instead of calling __array__ you instead call their .get method for explicit conversion to numpy. So we need to add a little compatibility code for this.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use pytorch as backend for xarrays 482543307

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);