issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR" and issue = 467865659 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Support keyword API for `Dataset.drop` · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
522358352 https://github.com/pydata/xarray/pull/3128#issuecomment-522358352 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjM1ODM1Mg== gwgundersen 2818208 2019-08-18T21:43:57Z 2019-08-18T21:43:57Z CONTRIBUTOR

Happy to make these changes, but what's the protocol here? Seems like reverting the merge and letting me amend is cleaner than me creating a new PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522299373 https://github.com/pydata/xarray/pull/3128#issuecomment-522299373 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjI5OTM3Mw== gwgundersen 2818208 2019-08-18T07:42:58Z 2019-08-18T07:42:58Z CONTRIBUTOR

@max-sixty, done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522275521 https://github.com/pydata/xarray/pull/3128#issuecomment-522275521 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjI3NTUyMQ== gwgundersen 2818208 2019-08-17T22:34:21Z 2019-08-17T22:34:21Z CONTRIBUTOR

Sorry for the back-and-forth. CI tests and checks are all passing, and this is ready for another review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
522225177 https://github.com/pydata/xarray/pull/3128#issuecomment-522225177 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMjIyNTE3Nw== gwgundersen 2818208 2019-08-17T10:22:58Z 2019-08-17T10:22:58Z CONTRIBUTOR

Now the docs don't build. When I try to build locally, I get a vague error:

bash File "/Users/gwg/miniconda3/envs/xarray-docs/lib/python3.7/site-packages/IPython/sphinxext/ipython_directive.py", line 583, in process_input raise RuntimeError('Non Expected warning in `{}` line {}'.format(filename, lineno)) RuntimeError: Non Expected warning in `/Users/gwg/projects/xarray/doc/indexing.rst` line 241

Do you see anything wrong with this?

``rest The :py:meth:~xarray.Dataset.drop` method returns a new object with the listed index labels along a dimension dropped:

.. ipython:: python

ds.drop(['IN', 'IL'], dim='space')

<-- line 241 drop is both a Dataset and DataArray method.

Use :py:meth:~xarray.Dataset.drop_dims to drop a full dimension from a Dataset. Any variables with these dimensions are also dropped: ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
521908280 https://github.com/pydata/xarray/pull/3128#issuecomment-521908280 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMTkwODI4MA== gwgundersen 2818208 2019-08-16T07:00:37Z 2019-08-16T07:00:37Z CONTRIBUTOR

Sorry about that. I'm not sure what happened. I've reverted branch and cherry picked my changes. The issue with drop being a duplicated name still stands.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659
521819936 https://github.com/pydata/xarray/pull/3128#issuecomment-521819936 https://api.github.com/repos/pydata/xarray/issues/3128 MDEyOklzc3VlQ29tbWVudDUyMTgxOTkzNg== gwgundersen 2818208 2019-08-15T22:29:36Z 2019-08-15T22:29:36Z CONTRIBUTOR

@max-sixty, thanks! It's useful to be able to do in advance.

After merging from master, I get this error:

flake8 ./xarray/core/dataset.py:3466:5: F811 redefinition of unused 'drop' from line 3460

I assume this is due to https://github.com/pydata/xarray/pull/3177 cc @crusaderky. Is there a way to avoid this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support keyword API for `Dataset.drop` 467865659

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);