issue_comments

Table actions

7 rows where author_association = "CONTRIBUTOR" and issue = 411755105 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Improved default behavior when concatenating DataArrays · 7 ✖

author_association 1

  • CONTRIBUTOR · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
469067311 https://github.com/pydata/xarray/pull/2777#issuecomment-469067311 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2OTA2NzMxMQ== Zac-HD 12229877 2019-03-03T21:41:21Z 2019-03-03T21:41:21Z CONTRIBUTOR

No objection to going with #2792; I'm just happy to have the change merged 😄

It would be nice for someone to cherry-pick 63da214d697345ebdd0ecc0967c72eafc70bcb0d before releasing 0.12 though, just to fix that warning.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105
467667604 https://github.com/pydata/xarray/pull/2777#issuecomment-467667604 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2NzY2NzYwNA== Zac-HD 12229877 2019-02-27T00:07:34Z 2019-02-27T00:07:34Z CONTRIBUTOR

maybe you have a syntax error?

...yep, an unmatched paren. 😥

If a and b have the same name, then you'd get an index with the two duplicate entries in the second case but not the first case. [which would be bad]

I think it's impossible to avoid this when using inference in the general case. Two options I think would be decent-if-unsatisfying:

  1. Explicitly manage this in the new combining functions, e.g. clear the concat dim coords if they are not unique and the input arrays did not have coords in that dimension.
  2. Add an argument to xr.concat to enable or disable this, e.g. infer_coords=True, and disable it when calling xr.concat from other combining functions.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105
466587431 https://github.com/pydata/xarray/pull/2777#issuecomment-466587431 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2NjU4NzQzMQ== Zac-HD 12229877 2019-02-22T23:47:30Z 2019-02-22T23:47:30Z CONTRIBUTOR

@shoyer - don't worry about the docs build, I'm pretty sure that was just a flaky network from Travis and it's working now in any case.

I've left tutorial.load_dataset in, just changed "removed in 0.12" to "removed in a future version".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105
466369284 https://github.com/pydata/xarray/pull/2777#issuecomment-466369284 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2NjM2OTI4NA== Zac-HD 12229877 2019-02-22T11:41:37Z 2019-02-22T11:41:37Z CONTRIBUTOR

OK! @shoyer, I've got everything passing and it's ready for review.

Even the accidental tutorial/docs fixes :smile: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105
465812738 https://github.com/pydata/xarray/pull/2777#issuecomment-465812738 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2NTgxMjczOA== Zac-HD 12229877 2019-02-21T00:32:10Z 2019-02-21T00:32:10Z CONTRIBUTOR

Hmm, it looks like the failure to download the naturalearth coastlines.zip wasn't so transient after all - but it does work on my machine!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105
465802643 https://github.com/pydata/xarray/pull/2777#issuecomment-465802643 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2NTgwMjY0Mw== Zac-HD 12229877 2019-02-20T23:51:04Z 2019-02-20T23:51:15Z CONTRIBUTOR

The docs build failed due to a (transient) http error when loading tutorial data for the docs, so I've also finalised the planned conversion from xarray.tutorial.load_dataset to xarray.tutorial.open_dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105
465029759 https://github.com/pydata/xarray/pull/2777#issuecomment-465029759 https://api.github.com/repos/pydata/xarray/issues/2777 MDEyOklzc3VlQ29tbWVudDQ2NTAyOTc1OQ== Zac-HD 12229877 2019-02-19T08:11:56Z 2019-02-19T08:11:56Z CONTRIBUTOR

Thanks for the support and quick review @shoyer!

Any idea when Xarray 0.12 might be out? I'm teaching some remote sensing workshops in mid-March and would love to have this merged, as a colleague's review of those notebooks prompted this PR 😄 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improved default behavior when concatenating DataArrays 411755105

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);