issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR" and issue = 382497709 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Zarr consolidated · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
444514608 https://github.com/pydata/xarray/pull/2559#issuecomment-444514608 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0NDUxNDYwOA== martindurant 6042212 2018-12-05T14:58:58Z 2018-12-05T14:58:58Z CONTRIBUTOR

I like those timings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709
443804859 https://github.com/pydata/xarray/pull/2559#issuecomment-443804859 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0MzgwNDg1OQ== martindurant 6042212 2018-12-03T17:55:51Z 2018-12-03T17:55:51Z CONTRIBUTOR

LGTM

Do you think there should be more explicit text of how to add consolidation to existing zarr/xarray data-sets, rather than creating them with consolidation turned on?

We may also need some text around updating consolidated data-sets, but that can maybe wait to see what kind of usage people try.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709
442801741 https://github.com/pydata/xarray/pull/2559#issuecomment-442801741 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0MjgwMTc0MQ== alimanfoo 703554 2018-11-29T11:33:33Z 2018-11-29T11:33:33Z CONTRIBUTOR

Great to see this. On the API, FWIW I'd vote for using the same keyword (consolidated) in both, less burden on the user to remember what to use.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709
442581092 https://github.com/pydata/xarray/pull/2559#issuecomment-442581092 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0MjU4MTA5Mg== martindurant 6042212 2018-11-28T19:49:43Z 2018-11-28T19:49:43Z CONTRIBUTOR

Glad to see this happening, by the way. Once in, catalogs using intake-xarray can be updated and I don't thin the code will need to change.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709
442580432 https://github.com/pydata/xarray/pull/2559#issuecomment-442580432 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0MjU4MDQzMg== martindurant 6042212 2018-11-28T19:47:43Z 2018-11-28T19:47:43Z CONTRIBUTOR

Will the default for both options be False for the time being?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709
442569498 https://github.com/pydata/xarray/pull/2559#issuecomment-442569498 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0MjU2OTQ5OA== lilyminium 31115101 2018-11-28T19:15:33Z 2018-11-28T19:15:33Z CONTRIBUTOR

I remember dealing with this in my pull request -- if I recall correctly scheduler was pointing to the scheduler.get function instead. It was a minor bug that was either fixed in the next release of xarray (0.11.0) or Dask (0.20.1).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);