issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR" and issue = 288465429 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Drop support for Python 3.4 · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
381366584 https://github.com/pydata/xarray/issues/1829#issuecomment-381366584 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM4MTM2NjU4NA== djhoese 1828519 2018-04-14T22:56:34Z 2018-04-14T22:56:34Z CONTRIBUTOR

Looks like it is related to pip 10.0, with pip 9.0.3 it seems to install pandas fine on Python 3.4. I'll continue debugging this with pandas and the pip projects. Thanks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
381365561 https://github.com/pydata/xarray/issues/1829#issuecomment-381365561 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM4MTM2NTU2MQ== djhoese 1828519 2018-04-14T22:38:33Z 2018-04-14T22:39:05Z CONTRIBUTOR

I just ran in to an issue testing Python 3.4 on Travis where xarray asked for pandas >0.18.0 which pulls in a version of pandas that is not compatible with Python 3.4 (https://github.com/pandas-dev/pandas/issues/20697). It also seems like this could be related to pip 10.0.

I'm ok dropping Python 3.4 from my tests, but is this python version check something pip/pypi should handle or is it something that xarray has to check in its setup.py?

Edit: I should have just made a new issue, sorry.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429
357812702 https://github.com/pydata/xarray/issues/1829#issuecomment-357812702 https://api.github.com/repos/pydata/xarray/issues/1829 MDEyOklzc3VlQ29tbWVudDM1NzgxMjcwMg== Zac-HD 12229877 2018-01-15T23:35:22Z 2018-01-15T23:35:22Z CONTRIBUTOR

Related: when does Xarray plan to drop Python 2? IMO we should at least join python3statement.org and drop it by 2020, and clearly document the timeline whatever it happens to be.

I'd be keen for an earlier date TBH - keyword-only arguments are great, compatibility shims kinda suck, and dependencies are moving to py3-only at an increasing rate (including matplotlib 3.0, scheduled for July) - but can see the other argument too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop support for Python 3.4 288465429

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);