issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR", issue = 220160378 and user = 1964655 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • ghisvail · 6 ✖

issue 1

  • Include missing conftest.py · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
292738236 https://github.com/pydata/xarray/pull/1358#issuecomment-292738236 https://api.github.com/repos/pydata/xarray/issues/1358 MDEyOklzc3VlQ29tbWVudDI5MjczODIzNg== ghisvail 1964655 2017-04-08T18:54:54Z 2017-04-08T18:54:54Z CONTRIBUTOR

And it looks like most projects in the Debian archive using pytest_addoption have it declared either as a plugin or inside the tests folder, as the note in the pytest documentation says.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include missing conftest.py 220160378
292738027 https://github.com/pydata/xarray/pull/1358#issuecomment-292738027 https://api.github.com/repos/pydata/xarray/issues/1358 MDEyOklzc3VlQ29tbWVudDI5MjczODAyNw== ghisvail 1964655 2017-04-08T18:51:59Z 2017-04-08T18:51:59Z CONTRIBUTOR

I can get the tests to work at build time

By adding conftest.py manually if that was not clear.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include missing conftest.py 220160378
292737976 https://github.com/pydata/xarray/pull/1358#issuecomment-292737976 https://api.github.com/repos/pydata/xarray/issues/1358 MDEyOklzc3VlQ29tbWVudDI5MjczNzk3Ng== ghisvail 1964655 2017-04-08T18:51:13Z 2017-04-08T18:51:13Z CONTRIBUTOR

I can get the tests to work at build time, but the CI tests using --pyargs (to test against the installed library under site-packages) no longer do, i.e. I get a bunch of ValueError: no option named '--run-flaky'

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include missing conftest.py 220160378
292737868 https://github.com/pydata/xarray/pull/1358#issuecomment-292737868 https://api.github.com/repos/pydata/xarray/issues/1358 MDEyOklzc3VlQ29tbWVudDI5MjczNzg2OA== ghisvail 1964655 2017-04-08T18:49:23Z 2017-04-08T18:49:23Z CONTRIBUTOR

There is a special note for pytest_addoption which might explain the problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include missing conftest.py 220160378
292698431 https://github.com/pydata/xarray/pull/1358#issuecomment-292698431 https://api.github.com/repos/pydata/xarray/issues/1358 MDEyOklzc3VlQ29tbWVudDI5MjY5ODQzMQ== ghisvail 1964655 2017-04-08T06:23:31Z 2017-04-08T06:23:31Z CONTRIBUTOR

Another alternative is to make the test-suite robust to its absence, and not bother to packaging it, given that it is mostly useful for development purposes.

If by packaging you mean distributing here, then I am very disappointed by your statement. From a package maintainer's perspective, I would consider the lack of a test suite a severe regression, should the latter be removed from source distribution in the future.

I would also remind you that it is that very same test suite that lead to the triage of the regressions with bottleneck whilst I was bootstrapping the Debian packaging effort.

Please consider fixing the current test suite or reverting to the old design. The fact that conftest.py does not work reliably (see the bug linked above) should be a sign that the decision to jump to this design happened too soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include missing conftest.py 220160378
292494259 https://github.com/pydata/xarray/pull/1358#issuecomment-292494259 https://api.github.com/repos/pydata/xarray/issues/1358 MDEyOklzc3VlQ29tbWVudDI5MjQ5NDI1OQ== ghisvail 1964655 2017-04-07T09:56:39Z 2017-04-07T09:56:39Z CONTRIBUTOR

Unfortunately, even if I patch the code base to add the missing file, the tests cannot be run due to the following bug: https://github.com/pytest-dev/pytest/issues/1889

Too bad you guys decided to change the design of the test suite for a point release :-(

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Include missing conftest.py 220160378

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);