home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 292698431

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1358#issuecomment-292698431 https://api.github.com/repos/pydata/xarray/issues/1358 292698431 MDEyOklzc3VlQ29tbWVudDI5MjY5ODQzMQ== 1964655 2017-04-08T06:23:31Z 2017-04-08T06:23:31Z CONTRIBUTOR

Another alternative is to make the test-suite robust to its absence, and not bother to packaging it, given that it is mostly useful for development purposes.

If by packaging you mean distributing here, then I am very disappointed by your statement. From a package maintainer's perspective, I would consider the lack of a test suite a severe regression, should the latter be removed from source distribution in the future.

I would also remind you that it is that very same test suite that lead to the triage of the regressions with bottleneck whilst I was bootstrapping the Debian packaging effort.

Please consider fixing the current test suite or reverting to the old design. The fact that conftest.py does not work reliably (see the bug linked above) should be a sign that the decision to jump to this design happened too soon.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  220160378
Powered by Datasette · Queries took 239.94ms · About: xarray-datasette