home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

9 rows where author_association = "CONTRIBUTOR", issue = 173632183 and user = 296686 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • robintw · 9 ✖

issue 1

  • Added convenience method for saving DataArray to netCDF file · 9 ✖

author_association 1

  • CONTRIBUTOR · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
244801125 https://github.com/pydata/xarray/pull/990#issuecomment-244801125 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0NDgwMTEyNQ== robintw 296686 2016-09-05T19:14:38Z 2016-09-05T19:14:38Z CONTRIBUTOR

I realised that the reason that Travis and AppVeyor weren't running properly was because there were conflicts between this PR and master. I think I've managed to rebase and push properly - but let me know if I've done anything wrong.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
244539361 https://github.com/pydata/xarray/pull/990#issuecomment-244539361 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0NDUzOTM2MQ== robintw 296686 2016-09-03T10:36:03Z 2016-09-03T10:36:03Z CONTRIBUTOR

Ah ok - that works (not entirely sure why, but it works!)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
244510329 https://github.com/pydata/xarray/pull/990#issuecomment-244510329 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0NDUxMDMyOQ== robintw 296686 2016-09-02T23:35:24Z 2016-09-02T23:35:24Z CONTRIBUTOR

Oops yes, sorry!

I'm having a bit of an issue with changing the strings to constants (which, by the way, I completely agree is how it should be done). I've defined the constants in backends/api.py and am then trying to import them in core/dataarray.py.

I am doing the import as:

from ..backends import DATAARRAY_NAME, DATAARRAY_VARIABLE

But this gives me the following error:

../../anaconda3/lib/python3.5/site-packages/py/_path/local.py:650: in pyimport __import__(modname) xarray/__init__.py:3: in <module> from .core.extensions import (register_dataarray_accessor, xarray/core/extensions.py:3: in <module> from .dataarray import DataArray xarray/core/dataarray.py:9: in <module> from ..backends import DATAARRAY_NAME, DATAARRAY_VARIABLE xarray/backends/__init__.py:8: in <module> from .netCDF4_ import NetCDF4DataStore xarray/backends/netCDF4_.py:6: in <module> from .. import Variable E ImportError: cannot import name 'Variable'

It seems like my relative import is somehow mucking up another relative import inside the netCDF4 stuff. Do you have any ideas how I can solve this? Am I just doing my imports wrong?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
244395018 https://github.com/pydata/xarray/pull/990#issuecomment-244395018 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0NDM5NTAxOA== robintw 296686 2016-09-02T14:44:24Z 2016-09-02T14:44:24Z CONTRIBUTOR

Great, thanks. I think I've done these changes (frustratingly I can't see a way to use *args/*kwargs after using the full argument list in the function definition, so I've had to write it out. Let me know if there is a better way, but I suspect there isn't).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
243951504 https://github.com/pydata/xarray/pull/990#issuecomment-243951504 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0Mzk1MTUwNA== robintw 296686 2016-09-01T01:33:25Z 2016-09-01T01:33:25Z CONTRIBUTOR

Thanks - I've got that working with the close() method, and I did it 'properly' using the BaseDataObject class.

The only failure on here now is the same as #991 - a conda error creating one of the environments.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
243946174 https://github.com/pydata/xarray/pull/990#issuecomment-243946174 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0Mzk0NjE3NA== robintw 296686 2016-09-01T00:56:50Z 2016-09-01T00:56:50Z CONTRIBUTOR

Also, it seems like there might be an issue with not closing the Dataset - but only on Windows (see the AppVeyor build failure at https://ci.appveyor.com/project/jhamman/xarray-injyf/build/1.0.268/job/kr8ss684ijxg55be).

Any ideas how this could be sorted without having to implement .close() for DataArray (or, alternatively, how to go about implementing that, given that I don't think a DataArray contains a reference to the Dataset that it may have come from)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
243929210 https://github.com/pydata/xarray/pull/990#issuecomment-243929210 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0MzkyOTIxMA== robintw 296686 2016-08-31T23:05:12Z 2016-08-31T23:05:12Z CONTRIBUTOR

Thanks for the useful comments.

I've added some bits to the Sphinx docs in the places that I think they should go - but let me know if I need to add any more.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
243863092 https://github.com/pydata/xarray/pull/990#issuecomment-243863092 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0Mzg2MzA5Mg== robintw 296686 2016-08-31T18:50:41Z 2016-08-31T18:50:41Z CONTRIBUTOR

I think I've dealt with the comments/issues now, but let me know if more needs doing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183
243000159 https://github.com/pydata/xarray/pull/990#issuecomment-243000159 https://api.github.com/repos/pydata/xarray/issues/990 MDEyOklzc3VlQ29tbWVudDI0MzAwMDE1OQ== robintw 296686 2016-08-28T21:20:44Z 2016-08-28T21:20:44Z CONTRIBUTOR

Thanks @shoyer - I wasn't actually aware that DataArrays can have a name before they're put into a Dataset (that's one of the things I love about contributing to OSS: you always learn things about the software that you never knew before!). I'll deal with the design issues ASAP.

How would you suggest testing this? I wasn't sure where to put the tests, and what exactly to test? Presumably something about the equivalence between this and saving after manually converting to a dataset, but I wasn't really sure how best to go about it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Added convenience method for saving DataArray to netCDF file 173632183

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 406.252ms · About: xarray-datasette