home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 243000159

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/990#issuecomment-243000159 https://api.github.com/repos/pydata/xarray/issues/990 243000159 MDEyOklzc3VlQ29tbWVudDI0MzAwMDE1OQ== 296686 2016-08-28T21:20:44Z 2016-08-28T21:20:44Z CONTRIBUTOR

Thanks @shoyer - I wasn't actually aware that DataArrays can have a name before they're put into a Dataset (that's one of the things I love about contributing to OSS: you always learn things about the software that you never knew before!). I'll deal with the design issues ASAP.

How would you suggest testing this? I wasn't sure where to put the tests, and what exactly to test? Presumably something about the equivalence between this and saving after manually converting to a dataset, but I wasn't really sure how best to go about it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  173632183
Powered by Datasette · Queries took 0.799ms · About: xarray-datasette