issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR" and issue = 1654022522 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • bad conda solve with pandas 2 · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1498164858 https://github.com/pydata/xarray/issues/7716#issuecomment-1498164858 https://api.github.com/repos/pydata/xarray/issues/7716 IC_kwDOAMm_X85ZTC56 jsignell 4806877 2023-04-05T21:09:59Z 2023-04-05T21:09:59Z CONTRIBUTOR

In that case it could be reasonable to mimic the pattern in test_groupby and mark the failing tests with a @pytest.mark.skipif(not has_pandas_version_two, reason="Tests a scenario that only raises when pandas <= 2")

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bad conda solve with pandas 2 1654022522
1498160636 https://github.com/pydata/xarray/issues/7716#issuecomment-1498160636 https://api.github.com/repos/pydata/xarray/issues/7716 IC_kwDOAMm_X85ZTB38 mroeschke 10647082 2023-04-05T21:05:34Z 2023-04-05T21:05:34Z CONTRIBUTOR

CI says these are the tests we'd need to fix:

Chiming in from the pandas side on those failures, I think they are all expected https://pandas.pydata.org/docs/whatsnew/v2.0.0.html namely

  • Since pandas supports s, ms and us numpy datetime resolutions now, I'm guessing that's why test_to_datetimeindex_out_of_range and test_should_cftime_be_used_source_outside_range are failing
  • For test_sel_float, pd.Index intentionally does not support np.float16 as dtype anymore (we never had an indexing engine for this dtype)
  • For test_maybe_coerce_to_str, this might be expected too as Index dtypes can hold np.int32 types now
 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bad conda solve with pandas 2 1654022522
1496186966 https://github.com/pydata/xarray/issues/7716#issuecomment-1496186966 https://api.github.com/repos/pydata/xarray/issues/7716 IC_kwDOAMm_X85ZLgBW ocefpaf 950575 2023-04-04T15:30:37Z 2023-04-04T15:30:37Z CONTRIBUTOR

@dcherian do you mind taking a look at https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/426? Please check the versions patched and the applied patch! Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bad conda solve with pandas 2 1654022522
1496107675 https://github.com/pydata/xarray/issues/7716#issuecomment-1496107675 https://api.github.com/repos/pydata/xarray/issues/7716 IC_kwDOAMm_X85ZLMqb ocefpaf 950575 2023-04-04T14:48:55Z 2023-04-04T14:48:55Z CONTRIBUTOR

We need to do a repodata patch for the current xarray. I'll get to it soon.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   bad conda solve with pandas 2 1654022522

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);