issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR", issue = 1319621859 and user = 4806877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • jsignell · 3 ✖

issue 1

  • Clarify difference between `.load()` and `.compute()` · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1197325700 https://github.com/pydata/xarray/issues/6837#issuecomment-1197325700 https://api.github.com/repos/pydata/xarray/issues/6837 IC_kwDOAMm_X85HXb2E jsignell 4806877 2022-07-27T20:21:36Z 2022-07-27T20:21:36Z CONTRIBUTOR

I should say that there might very well be other uses of load that I am not aware of. The inplace vs not is just the only difference that I noticed in the context of dask-backed xarray objects.

From this discussion I think for dask-backed objects we should recommend using compute. Maybe that is enough of a decision.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify difference between `.load()` and `.compute()` 1319621859
1197078424 https://github.com/pydata/xarray/issues/6837#issuecomment-1197078424 https://api.github.com/repos/pydata/xarray/issues/6837 IC_kwDOAMm_X85HWfeY jsignell 4806877 2022-07-27T17:27:43Z 2022-07-27T17:27:43Z CONTRIBUTOR

I can imagine a scenario where load is de-emphasized in the narrative docs, and compute is used instead. It wouldn't have to be a formal deprecation, but it could be that compute is best practice.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify difference between `.load()` and `.compute()` 1319621859
1196874535 https://github.com/pydata/xarray/issues/6837#issuecomment-1196874535 https://api.github.com/repos/pydata/xarray/issues/6837 IC_kwDOAMm_X85HVtsn jsignell 4806877 2022-07-27T15:00:43Z 2022-07-27T15:00:43Z CONTRIBUTOR

Thanks for engaging with this! I think removing load probably makes the most sense. Making load an alias for compute would just continue the confusion since there wouldn't be a clear right way to do things.

I somehow assumed compute would only work with dask while load would also load our lazy array implementation into memory. Not sure how I got that impression, but maybe that's another argument to remove / align load?

I'm not quite sure I follow. Are there lazy array implementations other than dask in xarray?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify difference between `.load()` and `.compute()` 1319621859

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);