issue_comments

Table actions

5 rows where author_association = "CONTRIBUTOR" and issue = 1031275532 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Check for path-like objects rather than Path type, use os.fspath · 5 ✖

author_association 1

  • CONTRIBUTOR · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1085091126 https://github.com/pydata/xarray/pull/5879#issuecomment-1085091126 https://api.github.com/repos/pydata/xarray/issues/5879 IC_kwDOAMm_X85ArS02 martindurant 6042212 2022-03-31T20:45:54Z 2022-03-31T20:45:54Z CONTRIBUTOR

OK, I get you - so the real problem is that OpenFile can look path-like, but isn't really.

OpenFile is really a file-like factory, a proxy for open file-likes that you can make (and seialise for Dask). Its main purpose is to be used in a context: python with fsspec.open(url) as f: ds = xr.open_dataset(f, engine="h5netcdf") except that the problem with xarray is that it will want to keep this thing open for subsequent operations, so you either need to put all that in the context, or use .open()/.close() as you have been.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for path-like objects rather than Path type, use os.fspath 1031275532
1085037801 https://github.com/pydata/xarray/pull/5879#issuecomment-1085037801 https://api.github.com/repos/pydata/xarray/issues/5879 IC_kwDOAMm_X85ArFzp martindurant 6042212 2022-03-31T19:54:26Z 2022-03-31T19:54:26Z CONTRIBUTOR

"s3://noaa-nwm-retrospective-2-1-zarr-pds/lakeout.zarr" is a directory, right? You cannot open that as a file, or maybe there is no equivalent key at all (because s3 is magic like that). No, you should not be able to do this directly - zarr requires a path which fsspec can turn into a mapper, or an instantiated mapper.

To make a bare mapper (i.e., dict-like): m = fsspec.get_mapper("s3://noaa-nwm-retrospective-2-1-zarr-pds/lakeout.zarr", ...) or you could use zarr's FSMapper meant specifically for this job.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for path-like objects rather than Path type, use os.fspath 1031275532
1085022939 https://github.com/pydata/xarray/pull/5879#issuecomment-1085022939 https://api.github.com/repos/pydata/xarray/issues/5879 IC_kwDOAMm_X85ArCLb martindurant 6042212 2022-03-31T19:37:49Z 2022-03-31T19:37:49Z CONTRIBUTOR

isinstance(X, os.PathLike) is very like hasattr(X, __fspath__) because of: python @classmethod def __subclasshook__(cls, subclass): if cls is PathLike: return _check_methods(subclass, '__fspath__') return NotImplemented

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for path-like objects rather than Path type, use os.fspath 1031275532
947575414 https://github.com/pydata/xarray/pull/5879#issuecomment-947575414 https://api.github.com/repos/pydata/xarray/issues/5879 IC_kwDOAMm_X844etp2 github-actions[bot] 41898282 2021-10-20T11:29:04Z 2021-10-27T23:00:52Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   54m 54s :stopwatch: 16 210 tests 14 474 :heavy_check_mark: 1 736 :zzz: 0 :x: 90 456 runs  82 276 :heavy_check_mark: 8 180 :zzz: 0 :x:

Results for commit 88589cb1.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for path-like objects rather than Path type, use os.fspath 1031275532
950734046 https://github.com/pydata/xarray/pull/5879#issuecomment-950734046 https://api.github.com/repos/pydata/xarray/issues/5879 IC_kwDOAMm_X844qwze mwtoews 895458 2021-10-25T09:46:37Z 2021-10-25T09:46:37Z CONTRIBUTOR

@max-sixty whats-new entry added, check to see if the paragraph is ok. I'll hold off clarifying file-like vs path-like in the docs for now, but will consider a doc intersphinx link at some time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for path-like objects rather than Path type, use os.fspath 1031275532

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);