issue_comments

Table actions

5 rows where author_association = "CONTRIBUTOR" and issue = 1030492705 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • _season_from_months can now handle np.nan · 5 ✖

author_association 1

  • CONTRIBUTOR · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
957930204 https://github.com/pydata/xarray/pull/5876#issuecomment-957930204 https://api.github.com/repos/pydata/xarray/issues/5876 IC_kwDOAMm_X845GNrc pierreloicq 8809578 2021-11-02T16:40:31Z 2021-11-02T16:40:31Z CONTRIBUTOR

I did not manage to add the test on the @requires_cftime def test_seasons: cftime_date_type(np.datetime64("NaT")) or cftime_date_type(np.nan) are not allowed

Feel free to add it if you understand that more than me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _season_from_months can now handle np.nan 1030492705
946897283 https://github.com/pydata/xarray/pull/5876#issuecomment-946897283 https://api.github.com/repos/pydata/xarray/issues/5876 IC_kwDOAMm_X844cIGD github-actions[bot] 41898282 2021-10-19T16:31:49Z 2021-11-02T16:37:14Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   53m 13s :stopwatch: 16 209 tests 14 473 :heavy_check_mark: 1 736 :zzz: 0 :x: 90 450 runs  82 270 :heavy_check_mark: 8 180 :zzz: 0 :x:

Results for commit 817b42f3.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _season_from_months can now handle np.nan 1030492705
957890546 https://github.com/pydata/xarray/pull/5876#issuecomment-957890546 https://api.github.com/repos/pydata/xarray/issues/5876 IC_kwDOAMm_X845GD_y pierreloicq 8809578 2021-11-02T16:10:15Z 2021-11-02T16:10:15Z CONTRIBUTOR

I don't understand this test fail. My modifications pass the tests on my computer. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _season_from_months can now handle np.nan 1030492705
948999461 https://github.com/pydata/xarray/pull/5876#issuecomment-948999461 https://api.github.com/repos/pydata/xarray/issues/5876 IC_kwDOAMm_X844kJUl pierreloicq 8809578 2021-10-21T21:01:31Z 2021-10-21T21:01:31Z CONTRIBUTOR

Indeed, but it looks like they were corrected automatically, right ? If so, I need to wait 5875 to pass ?

Le jeu. 21 oct. 2021 à 20:29, Illviljan @.***> a écrit :

=========================== short test summary info ============================ FAILED xarray/tests/test_backends.py::TestPseudoNetCDFFormat::test_ict_format FAILED xarray/tests/test_backends.py::TestPseudoNetCDFFormat::test_ict_format_write = 2 failed, 13692 passed, 1110 skipped, 226 xfailed, 66 xpassed, 128 warnings in 549.50s (0:09:09) =

Will be fixed in #5875 https://github.com/pydata/xarray/pull/5875.

But there's a few code linting errors which pep8speaks is also complaining about.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/5876#issuecomment-948893303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDGY2VM4DWDE6ZXM2K63HDUIBL2FANCNFSM5GJQ3F2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _season_from_months can now handle np.nan 1030492705
948358184 https://github.com/pydata/xarray/pull/5876#issuecomment-948358184 https://api.github.com/repos/pydata/xarray/issues/5876 IC_kwDOAMm_X844hswo pierreloicq 8809578 2021-10-21T08:00:48Z 2021-10-21T08:00:48Z CONTRIBUTOR

Hello, I tried some rapid change without even cloning the code. Can someone look at the failing tests ? some don't seem related to my modification.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   _season_from_months can now handle np.nan 1030492705

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);