issue_comments

Table actions

8 rows where author_association = "CONTRIBUTOR" and issue = 1020407925 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • remove requirement for setuptools.pkg_resources · 8 ✖

author_association 1

  • CONTRIBUTOR · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
959835614 https://github.com/pydata/xarray/pull/5845#issuecomment-959835614 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X845Ne3e marscher 170287 2021-11-03T19:04:45Z 2021-11-03T19:04:45Z CONTRIBUTOR

Thanks @marscher This is a great change.

I see this is your first PR. Welcome to Xarray!

Thanks for the warm welcome.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
938114133 https://github.com/pydata/xarray/pull/5845#issuecomment-938114133 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X8436nxV github-actions[bot] 41898282 2021-10-07T20:02:55Z 2021-10-29T17:40:36Z CONTRIBUTOR

Unit Test Results

0 files  0 suites   0s :stopwatch: 0 tests 0 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 28c84858.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
954595452 https://github.com/pydata/xarray/pull/5845#issuecomment-954595452 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X8445fh8 marscher 170287 2021-10-29T09:32:34Z 2021-10-29T09:32:34Z CONTRIBUTOR

All suggestions of yours are now included and CI is green. Thank you all very much for your review and suggestions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
953722459 https://github.com/pydata/xarray/pull/5845#issuecomment-953722459 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X8442KZb marscher 170287 2021-10-28T10:37:30Z 2021-10-28T10:37:30Z CONTRIBUTOR

I installed the precommit hook and everything passed locally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
953259849 https://github.com/pydata/xarray/pull/5845#issuecomment-953259849 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X8440ZdJ marscher 170287 2021-10-27T19:53:32Z 2021-10-27T19:53:32Z CONTRIBUTOR

I wonder if there are any tests for the backend entry points or if tests are just being skipped if the mandatory backends are unavailble (due to a bug introduced by switching from pkg_resources). I have like 5600 skipped tests when I naively invoke pytest. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
951404731 https://github.com/pydata/xarray/pull/5845#issuecomment-951404731 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X844tUi7 dopplershift 221526 2021-10-25T23:10:25Z 2021-10-25T23:10:25Z CONTRIBUTOR

You cannot use selectors with noarch conda packages. Full stop.

For conda-forge, it's perfectly fine to just unconditionally depend on the importlib_metadata backport, especially with the implementation done like here where you use the std lib version and fall back.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
946419161 https://github.com/pydata/xarray/pull/5845#issuecomment-946419161 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X844aTXZ marscher 170287 2021-10-19T06:56:22Z 2021-10-19T06:56:22Z CONTRIBUTOR

If one installs local packages with conda, all dependencies are ignored (--use-local flag). I have not yet figured out, why this is the case due to a lack of time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925
939985659 https://github.com/pydata/xarray/pull/5845#issuecomment-939985659 https://api.github.com/repos/pydata/xarray/issues/5845 IC_kwDOAMm_X844Bwr7 marscher 170287 2021-10-11T12:29:19Z 2021-10-11T12:38:01Z CONTRIBUTOR

I don't think that noarch packages are restricted to python version selectors any more. I've tested this locally with a dummy recipe like this: ```yaml package: name: {{ name|lower }} version: {{ version }}

source: path: .

build: noarch: python number: 0 script: "{{ PYTHON }} -m pip install . -vv"

requirements: host: - python - pip run: - python - importlib_metadata # [ py < 38] ``` This creates a noarch package as expected with a recent conda/build version.

This means you can merge this and still use a noarch package on Conda-forge, which will conditionally install the backport importlib-metadata package for older Python versions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove requirement for setuptools.pkg_resources 1020407925

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);