issue_comments

Table actions

4 rows where author_association = "COLLABORATOR" and issue = 423742774 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Dataset.copy(deep=True) does not deepcopy .attrs · 4 ✖

author_association 1

  • COLLABORATOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1258593420 https://github.com/pydata/xarray/issues/2835#issuecomment-1258593420 https://api.github.com/repos/pydata/xarray/issues/2835 IC_kwDOAMm_X85LBJyM headtr1ck 43316012 2022-09-26T20:28:28Z 2022-09-26T20:28:28Z COLLABORATOR

Ok, I thought that copying attrs was fixed. Seems like it did not... I will create a PR to fix this first, then we can use your test :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.copy(deep=True) does not deepcopy .attrs 423742774
1258235669 https://github.com/pydata/xarray/issues/2835#issuecomment-1258235669 https://api.github.com/repos/pydata/xarray/issues/2835 IC_kwDOAMm_X85K_ycV headtr1ck 43316012 2022-09-26T15:41:22Z 2022-09-26T15:41:22Z COLLABORATOR

Absolutely @headtr1ck, glad that it was useful - I'm a bit green re: tests and PRs to large projects, but will make a stab at it. I'm just consulting the Contributing guide now.

Great! Just ask if you need help :)

Basically: fork repo, make new branch on your forked repo, add test, create PR (when you push GitHub should show a popup asking if you want to create a PR anyway).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.copy(deep=True) does not deepcopy .attrs 423742774
1256569748 https://github.com/pydata/xarray/issues/2835#issuecomment-1256569748 https://api.github.com/repos/pydata/xarray/issues/2835 IC_kwDOAMm_X85K5buU headtr1ck 43316012 2022-09-23T18:59:33Z 2022-09-23T18:59:33Z COLLABORATOR

I see, so it was a problem of recursively copying the attrs. @phockett would you be open to add your example as a test in a PR such that we can avoid this in the future?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.copy(deep=True) does not deepcopy .attrs 423742774
1236356402 https://github.com/pydata/xarray/issues/2835#issuecomment-1236356402 https://api.github.com/repos/pydata/xarray/issues/2835 IC_kwDOAMm_X85JsU0y headtr1ck 43316012 2022-09-04T14:41:39Z 2022-09-04T14:41:39Z COLLABORATOR

Cannot reproduce on current master using ```python import xarray as xr

ds = xr.Dataset({"a": (["x"], [1, 2, 3])}, attrs={"t": 1}) ds2 = ds.copy(deep=True) ds.attrs["t"] = 5 print(ds2.attrs) # returns: {'t': 1} ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.copy(deep=True) does not deepcopy .attrs 423742774

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);