issue_comments

Table actions

10 rows where author_association = "COLLABORATOR" and issue = 1363829843 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • list available backends and basic descriptors · 10 ✖

author_association 1

  • COLLABORATOR · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1281111474 https://github.com/pydata/xarray/pull/7000#issuecomment-1281111474 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85MXDWy headtr1ck 43316012 2022-10-17T16:07:15Z 2022-10-17T16:07:15Z COLLABORATOR

@headtr1ck the typing changes didn't work. Can you send in a separate PR for that please?

Ok, weird. But can do :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1279051058 https://github.com/pydata/xarray/pull/7000#issuecomment-1279051058 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85MPMUy headtr1ck 43316012 2022-10-14T14:01:09Z 2022-10-14T14:01:09Z COLLABORATOR

@headtr1ck GitHub is unhelpfully not showing me any comments. Can you share a screen shot or something so I can address them? Thanks!

Forgot to click the ok button, haha

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1278530999 https://github.com/pydata/xarray/pull/7000#issuecomment-1278530999 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85MNNW3 headtr1ck 43316012 2022-10-14T06:11:18Z 2022-10-14T06:11:18Z COLLABORATOR

Couple of minor comments, then we can merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1275127741 https://github.com/pydata/xarray/pull/7000#issuecomment-1275127741 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85MAOe9 headtr1ck 43316012 2022-10-11T18:47:36Z 2022-10-11T18:47:36Z COLLABORATOR

@JessicaS11 if you merge master and solve the conflicts this should be enough for a merge :)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1267353500 https://github.com/pydata/xarray/pull/7000#issuecomment-1267353500 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85Likec headtr1ck 43316012 2022-10-04T17:51:52Z 2022-10-04T17:51:52Z COLLABORATOR

Looks like they are - every subclass of BackendEntryPoint seems to define .available. In each case it points to the corresponding has_[package] flag. I think it might be safe to set .available to default to True in the base class? That way if the backend requires no special dependencies it would by default return True. If we think that makes sense then I'm happy to add a commit doing that so this can be merged.

EDIT: (Actually we should wait to put tests in too really)

In #7114 I have added this class attribute with default = True. Maybe we can merge this first?

Which tests did you want to see?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1257279210 https://github.com/pydata/xarray/pull/7000#issuecomment-1257279210 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85K8I7q headtr1ck 43316012 2022-09-25T21:03:21Z 2022-09-25T21:03:21Z COLLABORATOR

Does anyone know if the backentrypoints are supposed to have an available attribute? This: https://github.com/pydata/xarray/blob/212a5d7909e8dd54446b08574a0683e2477f2b40/xarray/backends/plugins.py#L89 seems to require one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1242724087 https://github.com/pydata/xarray/pull/7000#issuecomment-1242724087 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85KEnb3 headtr1ck 43316012 2022-09-10T13:02:22Z 2022-09-10T13:02:22Z COLLABORATOR

So what would the return type need to be to get a nice table representation, but also allow you to select out individual backend objects? A pandas object containing the backend objects? Some kind of BackendList class?

Does it need to be the same method? Why not a method that simply returns a list of classes and another method that prints a nicely formatted list?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1240937440 https://github.com/pydata/xarray/pull/7000#issuecomment-1240937440 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85J9zPg headtr1ck 43316012 2022-09-08T16:19:43Z 2022-09-08T16:19:43Z COLLABORATOR

Correct me if I'm wrong, but if a subclassed ZarrBackend object was added as an entrypoint under the key "zarr", wouldn't type(self).__name__ return "ZarrBackend" rather than "zarr", even though "zarr" is what the user would actually have to pass to the engine kwarg of open_dataset to use that backend? Not ideal :/

You're right. But this mapping has to be somewhere.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1240912040 https://github.com/pydata/xarray/pull/7000#issuecomment-1240912040 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85J9tCo headtr1ck 43316012 2022-09-08T15:57:39Z 2022-09-08T15:57:39Z COLLABORATOR

One approach might be to add a nice __str__, __repr__, (or even _repr_html_) to the BackendEntrypoint class. That way printing a list (or better a dict) of the engine-specific subclasses would automatically look decent.

That would not display in a nice table though. But might be anyway nice to add ;)

What might be clearer is if this backend class knew it's own name, but I'm not sure it can, hmmm

What about type(self).__name__

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843
1238932679 https://github.com/pydata/xarray/pull/7000#issuecomment-1238932679 https://api.github.com/repos/pydata/xarray/issues/7000 IC_kwDOAMm_X85J2JzH headtr1ck 43316012 2022-09-07T05:45:09Z 2022-09-07T05:45:09Z COLLABORATOR

I know that it is more work but I think it would be more beneficial to have this information formated nicely than simply returning some lists. Maybe similar to a pandas dataframe?

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   list available backends and basic descriptors 1363829843

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);