home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1267353500

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/7000#issuecomment-1267353500 https://api.github.com/repos/pydata/xarray/issues/7000 1267353500 IC_kwDOAMm_X85Likec 43316012 2022-10-04T17:51:52Z 2022-10-04T17:51:52Z COLLABORATOR

Looks like they are - every subclass of BackendEntryPoint seems to define .available. In each case it points to the corresponding has_[package] flag. I think it might be safe to set .available to default to True in the base class? That way if the backend requires no special dependencies it would by default return True. If we think that makes sense then I'm happy to add a commit doing that so this can be merged.

EDIT: (Actually we should wait to put tests in too really)

In #7114 I have added this class attribute with default = True. Maybe we can merge this first?

Which tests did you want to see?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1363829843
Powered by Datasette · Queries took 0.626ms · About: xarray-datasette