issue_comments

Table actions

3 rows where author_association = "COLLABORATOR" and issue = 1331985070 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Passing extra keyword arguments to `curvefit` throws an exception. · 3 ✖

author_association 1

  • COLLABORATOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1484199176 https://github.com/pydata/xarray/issues/6891#issuecomment-1484199176 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YdxUI headtr1ck 43316012 2023-03-26T19:30:08Z 2023-03-26T19:30:25Z COLLABORATOR

As said above, you don't have to change code to make it work. The intended way of using is da.curvefit(...., kwargs={"method": "trf"}).

You can submit a PR which changes **kwargs to kwargs in the docstring (both, Dataset.curvefit and DataArray.curvefit) and probably add some more info there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484195905 https://github.com/pydata/xarray/issues/6891#issuecomment-1484195905 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YdwhB headtr1ck 43316012 2023-03-26T19:16:38Z 2023-03-26T19:16:38Z COLLABORATOR

Actually, as @kmuehlbauer pointed out, we can address this for now by updating the docstring of the function. It should get clear the the extra kwargs are passed as a dict and not as **kwargs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484188179 https://github.com/pydata/xarray/issues/6891#issuecomment-1484188179 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YduoT headtr1ck 43316012 2023-03-26T19:02:12Z 2023-03-26T19:02:12Z COLLABORATOR

I think we should continue the discussion in https://github.com/pydata/xarray/issues/7130 since it is not clear which function signature (kwargs vs **kwargs) is preferred.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);