issue_comments

Table actions

13 rows where issue = 1331985070 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Passing extra keyword arguments to `curvefit` throws an exception. · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1484201647 https://github.com/pydata/xarray/issues/6891#issuecomment-1484201647 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85Ydx6v Amisha2778 100865724 2023-03-26T19:40:43Z 2023-03-26T19:40:43Z NONE

Got it, thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484199176 https://github.com/pydata/xarray/issues/6891#issuecomment-1484199176 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YdxUI headtr1ck 43316012 2023-03-26T19:30:08Z 2023-03-26T19:30:25Z COLLABORATOR

As said above, you don't have to change code to make it work. The intended way of using is da.curvefit(...., kwargs={"method": "trf"}).

You can submit a PR which changes **kwargs to kwargs in the docstring (both, Dataset.curvefit and DataArray.curvefit) and probably add some more info there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484197245 https://github.com/pydata/xarray/issues/6891#issuecomment-1484197245 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85Ydw19 Amisha2778 100865724 2023-03-26T19:22:17Z 2023-03-26T19:28:50Z NONE

@headtr1ck I tried by making some changes. There was only one function that I could find with the issue mentioned. But, I am getting some failed test cases.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484195905 https://github.com/pydata/xarray/issues/6891#issuecomment-1484195905 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YdwhB headtr1ck 43316012 2023-03-26T19:16:38Z 2023-03-26T19:16:38Z COLLABORATOR

Actually, as @kmuehlbauer pointed out, we can address this for now by updating the docstring of the function. It should get clear the the extra kwargs are passed as a dict and not as **kwargs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484188179 https://github.com/pydata/xarray/issues/6891#issuecomment-1484188179 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YduoT headtr1ck 43316012 2023-03-26T19:02:12Z 2023-03-26T19:02:12Z COLLABORATOR

I think we should continue the discussion in https://github.com/pydata/xarray/issues/7130 since it is not clear which function signature (kwargs vs **kwargs) is preferred.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484185066 https://github.com/pydata/xarray/issues/6891#issuecomment-1484185066 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85Ydt3q Amisha2778 100865724 2023-03-26T18:49:38Z 2023-03-26T18:49:38Z NONE

@TomNicholas Could you please help me out. Can I work on this issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1484184328 https://github.com/pydata/xarray/issues/6891#issuecomment-1484184328 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85YdtsI Amisha2778 100865724 2023-03-26T18:45:48Z 2023-03-26T18:45:48Z NONE

Hey! I'm an Outreachy intern, I would like to work on this issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1474986201 https://github.com/pydata/xarray/issues/6891#issuecomment-1474986201 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85X6oDZ husainridwan 61923007 2023-03-18T20:37:25Z 2023-03-18T20:37:25Z NONE

@TomNicholas I would like to work on this. Where do I start from?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1474137449 https://github.com/pydata/xarray/issues/6891#issuecomment-1474137449 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85X3Y1p kmuehlbauer 5821660 2023-03-17T17:03:09Z 2023-03-17T17:03:09Z MEMBER

Nevermind, I should read the complete issue, not only the last comment.

I think this is just a problem with the doc-string then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1474123299 https://github.com/pydata/xarray/issues/6891#issuecomment-1474123299 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85X3VYj kmuehlbauer 5821660 2023-03-17T16:51:49Z 2023-03-17T16:51:49Z MEMBER

@zoj613 Could you try to provide kwargs=kwargs? Where kwargs is a dict with method-key inside.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1474097791 https://github.com/pydata/xarray/issues/6891#issuecomment-1474097791 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85X3PJ_ zoj613 44142765 2023-03-17T16:30:58Z 2023-03-17T16:31:12Z NONE

@alrho007 I still get this error using version 2022.9.0: ```python In [1]: import pandas as pd [5/182] ...: import xarray as xr ...: import numpy as np ...: ...: da = xr.DataArray( ...: ...: np.random.rand(4, 3), ...: ...: [ ...: ...: ("time", pd.date_range("2000-01-01", periods=4)), ...: ...: ("space", ["IA", "IL", "IN"]), ...: ...: ], ...: ...: ) ...: da.curvefit(coords=["time"], func=lambda x, params: x, method="trf")

TypeError Traceback (most recent call last) Cell In[1], line 18 3 import numpy as np 5 da = xr.DataArray( 6 7 np.random.rand(4, 3), (...) 16 17 ) ---> 18 da.curvefit(coords=["time"], func=lambda x, params: x, method="trf")

TypeError: curvefit() got an unexpected keyword argument 'method'

In [2]: xr.version Out[2]: '2022.9.0' ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1473625704 https://github.com/pydata/xarray/issues/6891#issuecomment-1473625704 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85X1b5o husainridwan 61923007 2023-03-17T10:30:05Z 2023-03-17T10:30:05Z NONE

I think this depends on the version of xarray you’re using. Newer versions from at least 0.16.0 and later now support your MVCE. If you’re still using an older version, you’ll have to pass it as dictionary elements as you said. @zoj613 @TomNicholas, you can check this out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070
1208323478 https://github.com/pydata/xarray/issues/6891#issuecomment-1208323478 https://api.github.com/repos/pydata/xarray/issues/6891 IC_kwDOAMm_X85IBY2W TomNicholas 35968931 2022-08-08T16:10:17Z 2022-08-08T16:10:17Z MEMBER

Hi @zoj613 , thanks for the bug report. This should be a very simple fix, and your MVCE would make a great test for the behaviour. Would you be interested in contributing to xarray by submitting a PR with a fix? (No worries if you would rather we fix it, but if you are then we are always happy to welcome new contributors :grinning: )

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Passing extra keyword arguments to `curvefit` throws an exception. 1331985070

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);