issue_comments

Table actions

3 rows where author_association = "COLLABORATOR", issue = 1243123406 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • headtr1ck · 3 ✖

issue 1

  • CFTime support for polyval · 3 ✖

author_association 1

  • COLLABORATOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1140202248 https://github.com/pydata/xarray/pull/6624#issuecomment-1140202248 https://api.github.com/repos/pydata/xarray/issues/6624 IC_kwDOAMm_X85D9hsI headtr1ck 43316012 2022-05-28T08:04:08Z 2022-05-28T08:04:08Z COLLABORATOR

🤦🏾 the failure is because pytest is running the xr.date_range(..., use_cftime=True) always, ignoring the skipif mark.

@headtr1ck Can you add the cftime tests as a separate test instead? This will avoid the need for a max_computes arg too. For the separate cftime test, apply the requires_cftime decorator from tests/__init__.py to skip when cftime is not present.

Done. Seems to work :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CFTime support for polyval 1243123406
1135015329 https://github.com/pydata/xarray/pull/6624#issuecomment-1135015329 https://api.github.com/repos/pydata/xarray/issues/6624 IC_kwDOAMm_X85DpvWh headtr1ck 43316012 2022-05-23T18:40:56Z 2022-05-23T18:40:56Z COLLABORATOR

I don't understand why it is so much more complicated than before the new algo. Is it because before only indexes were supported as coord and they are never lazy?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CFTime support for polyval 1243123406
1133766467 https://github.com/pydata/xarray/pull/6624#issuecomment-1133766467 https://api.github.com/repos/pydata/xarray/issues/6624 IC_kwDOAMm_X85Dk-dD headtr1ck 43316012 2022-05-21T20:49:36Z 2022-05-21T20:50:38Z COLLABORATOR

Maybe someone with more insight into the inners of xarray cound fix that. I get a ValueError: `dtype` inference failed in `map_blocks`. for cftime arrays with dask.

Also, the part with the try-except around the compute seems strange, maybe there is an easier solution?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   CFTime support for polyval 1243123406

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);