home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 1140202248

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6624#issuecomment-1140202248 https://api.github.com/repos/pydata/xarray/issues/6624 1140202248 IC_kwDOAMm_X85D9hsI 43316012 2022-05-28T08:04:08Z 2022-05-28T08:04:08Z COLLABORATOR

🤦🏾 the failure is because pytest is running the xr.date_range(..., use_cftime=True) always, ignoring the skipif mark.

@headtr1ck Can you add the cftime tests as a separate test instead? This will avoid the need for a max_computes arg too. For the separate cftime test, apply the requires_cftime decorator from tests/__init__.py to skip when cftime is not present.

Done. Seems to work :)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1243123406
Powered by Datasette · Queries took 2.9ms · About: xarray-datasette