issues: 721853828

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
721853828 MDExOlB1bGxSZXF1ZXN0NTAzNzA0Njgy 4510 rolling keep_attrs & default True 10194086 closed 0     6 2020-10-14T23:12:16Z 2020-11-09T19:10:24Z 2020-11-09T15:35:41Z MEMBER   0 pydata/xarray/pulls/4510
  • [x] Closes #4497
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Only global attributes were retained for rolling operations. DataArrays would loose their attrs.

As per https://github.com/pydata/xarray/issues/3891#issuecomment-612522628 I also changed the default to True.

Note #4497 also mentions propagation of the name. This is not yet implemented.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4510/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables