home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 496826564

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
496826564 MDExOlB1bGxSZXF1ZXN0MzIwMDc4MzQ1 3333 More doc fixes 14808389 closed 0     7 2019-09-22T20:09:36Z 2019-09-23T10:46:34Z 2019-09-23T01:08:43Z MEMBER   0 pydata/xarray/pulls/3333

While going through the docs, I noticed several issues: * in reshaping.rst, a code block gets hidden because of a missing newline * in api.rst, the section What parts of xarray are considered public API? is referenced (I think), but the link is broken. * the code samples in DataArray.plot are not recognized as such because of missing newlines * the documentation of Dataset.plot.scatter in the API reference is broken

This PR tries to fix all of those, but while the first three issues are easy to fix, I'm not sure whether my proposed fix for the one involving scatter is correct: I've added plot.dataset_plot.scatter to plot.__all__ (exposing xr.plot.scatter) and changed api.rst to reference plot.scatter instead of Dataset.plot.scatter. It seems harmless to me, but the information that scatter only exists for Dataset is less visible. Is that the way to fix this?

  • [x] Passes black . && mypy . && flake8
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3333/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 7 rows from issue in issue_comments
Powered by Datasette · Queries took 1.774ms · About: xarray-datasette