issues: 484063701

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
484063701 MDExOlB1bGxSZXF1ZXN0MzEwMDE4Mjk1 3239 Refactor concat to use merge for non-concatenated variables 2448579 closed 0     4 2019-08-22T15:29:57Z 2019-09-16T14:49:32Z 2019-09-16T14:49:28Z MEMBER   0 pydata/xarray/pulls/3239

This PR adds two changes:

  1. First, it refactors concat so that non-concatenated variables are passed to merge. concat gains a compat kwarg which tells merge how to merge things. concat's previous behaviour was effectively compat='equals' which is now the default.

  2. Also adds compat="override" to skip equality checking in merge. concat's data_vars='minimal' and coords='minimal' options are now more useful because you can specify compat='override' to skip equality checking and just pick the first one. Previously this would raise an error if any of the variables differed by floating point noise.

  3. [x] xref #2064, closes #1823

  4. [x] Tests added
  5. [x] Passes black . && mypy . && flake8
  6. [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3239/reactions",
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables