issues: 322365966

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
322365966 MDExOlB1bGxSZXF1ZXN0MTg3NTE3MTUx 2120 Prevent Inf from screwing colorbar scale. 2448579 closed 0     1 2018-05-11T16:55:34Z 2019-08-15T15:32:51Z 2018-05-12T06:36:37Z MEMBER   0 pydata/xarray/pulls/2120
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

The current version uses pd.isnull to remove invalid values from input data when making a colorbar. pd.isnull([np.inf]) is False which means _determine_cmap_params returns Inf for colorbar limits which screws everything up. This PR changes pd.isnull to np.isfinite.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2120/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables