issues: 298672745

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
298672745 MDExOlB1bGxSZXF1ZXN0MTcwMjUyMTky 1928 facetgrid: unset cmap if colors is specified. 2448579 closed 0     2 2018-02-20T17:03:45Z 2018-05-10T05:12:03Z 2018-03-06T05:05:59Z MEMBER   0 pydata/xarray/pulls/1928
  • [x] Closes #1461
  • [x] Tests added
  • [x] Tests passed
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

This seemed the cleanest way to fix this. If both colors and cmap are specified, raise an error. If colors is specified and cmap was None, I set the auto-inferred cmap to None.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1928/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables