home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 285231087

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
285231087 MDExOlB1bGxSZXF1ZXN0MTYwNjA1MDkw 1803 Switch (some) coding/encoding in conventions.py to use xarray.coding. 1217238 closed 0     4 2017-12-30T23:59:11Z 2018-01-11T17:21:38Z 2018-01-11T16:53:09Z MEMBER   0 pydata/xarray/pulls/1803

Fixes #1781

The goal here is to eventually convert everything in xarray.conventions to using the new coding module, which is more modular and supports dask arrays. For now, I have switched over datetime, timedelta, unsigned integer, scaling and mask coding to use new coders. Integrating these into xarray.conventions lets us harness our existing test suite and delete a lot of redundant code.

Most of the code/tests is simply reorganized. There should be no changes to public API (to keep this manageable for review). All of the original tests that are still relevant should still be present, though I have reorganized many of them into new locations to match the revised code.

  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Passes git diff upstream/master **/*py | flake8 --diff (remove if you did not edit any Python files)
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1803/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 4 rows from issue in issue_comments
Powered by Datasette · Queries took 0.83ms · About: xarray-datasette