issues: 272460887
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 272460887 | MDExOlB1bGxSZXF1ZXN0MTUxNTc2MzA1 | 1705 | Make Indexer classes not inherit from tuple. | 1217238 | closed | 0 | 5 | 2017-11-09T07:08:27Z | 2017-11-17T16:33:40Z | 2017-11-14T03:32:34Z | MEMBER | 0 | pydata/xarray/pulls/1705 | I'm not entirely sure this is a good idea. The advantage is that it ensures that all our indexing code is entirely explicit: everything that reaches a backend must be an ExplicitIndexer. The downside is that it removes a bit of internal flexibility: we can't just use tuples in place of basic indexers anymore. On the whole, I think this is probably worth it but I would appreciate feedback. @fujiisoup can you take a look?
|
{
"url": "https://api.github.com/repos/pydata/xarray/issues/1705/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |