issues: 1362148668

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1362148668 PR_kwDOAMm_X84-YVgW 6992 Review (re)set_index 4160723 closed 0     1 2022-09-05T15:07:43Z 2023-08-30T09:05:10Z 2022-09-27T10:35:38Z MEMBER   0 pydata/xarray/pulls/6992
  • [x] Closes
  • [x] fixes #6946
  • [x] fixes #6989
  • [x] fixes #6959
  • [x] fixes #6969
  • [x] fixes #7036
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Restore behavior prior to the explicit indexes refactor (i.e., refactored but without breaking changes).

TODO:

  • [x] review set_index
  • [x] review reset_index

For reset_index, the only behavior that is not restored here is the coordinate renamed with a _ suffix when dropping a single index. This was originally to prevent any coordinate with no index matching a dimension name, which is now irrelevant. That is a quite dirty workaround and I don't know who is relying on it (no complaints yet), but I'm open to restore it if needed (esp. considering that we may later deprecate reset_index completely in favor of drop_indexes #6971).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6992/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables