issue_comments

Table actions

11 rows where issue = 663825726 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • allow customizing the inline repr of a duck array · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
670012106 https://github.com/pydata/xarray/pull/4248#issuecomment-670012106 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY3MDAxMjEwNg== dcherian 2448579 2020-08-06T15:49:02Z 2020-08-06T15:49:02Z MEMBER

Thanks @keewis

get rid of our inline_dask_repr and inline_sparse_repr functions by pushing that upstream

I think this is a great idea!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669624326 https://github.com/pydata/xarray/pull/4248#issuecomment-669624326 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTYyNDMyNg== max-sixty 5635139 2020-08-06T01:09:09Z 2020-08-06T01:09:09Z MEMBER

Perfect! Thanks for adding to the docs!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669616000 https://github.com/pydata/xarray/pull/4248#issuecomment-669616000 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTYxNjAwMA== keewis 14808389 2020-08-06T00:37:41Z 2020-08-06T00:37:41Z MEMBER

should be ready for review again

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669597198 https://github.com/pydata/xarray/pull/4248#issuecomment-669597198 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTU5NzE5OA== keewis 14808389 2020-08-05T23:31:19Z 2020-08-05T23:31:19Z MEMBER

I put it into internals for now, together with a small paragraph about the requirements on duck arrays, but this should definitely be extended and moved somewhere more visible – maybe a Extending xarray document, together with the current section about custom accessors?

I also added a test, but it feels a bit strange to compare the result with the return value of a direct call to the object's _repr_inline_.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669594219 https://github.com/pydata/xarray/pull/4248#issuecomment-669594219 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTU5NDIxOQ== dcherian 2448579 2020-08-05T23:21:28Z 2020-08-05T23:21:28Z MEMBER

"internals" sounds good to me. It could also go in the future NEP-18 wrapping section.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669576665 https://github.com/pydata/xarray/pull/4248#issuecomment-669576665 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTU3NjY2NQ== keewis 14808389 2020-08-05T22:47:13Z 2020-08-05T22:47:13Z MEMBER

tests are a good point, and I guess this should also be documented somewhere. Any ideas where that could be? Internals?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669571543 https://github.com/pydata/xarray/pull/4248#issuecomment-669571543 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTU3MTU0Mw== max-sixty 5635139 2020-08-05T22:44:01Z 2020-08-05T22:44:11Z MEMBER

LGTM! A test wouldn't go amiss but fine to keep moving given the size of the change imo

Thank you @keewis !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669564552 https://github.com/pydata/xarray/pull/4248#issuecomment-669564552 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTU2NDU1Mg== keewis 14808389 2020-08-05T22:39:42Z 2020-08-05T22:39:42Z MEMBER

if I remember correctly, this was accepted in this week's community meeting. Should this be merged, then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669289892 https://github.com/pydata/xarray/pull/4248#issuecomment-669289892 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTI4OTg5Mg== keewis 14808389 2020-08-05T16:17:55Z 2020-08-05T16:17:55Z MEMBER

I think _repr_*_ is the standard from IPython/Jupyter

exactly, that's where the name came from.

Also, if consistency with the functions in xarray.core.formatting is important it might be better to choose _repr_inline_: the short_*_repr functions simply shorten the normal repr.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669287050 https://github.com/pydata/xarray/pull/4248#issuecomment-669287050 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTI4NzA1MA== jthielen 3460034 2020-08-05T16:13:06Z 2020-08-05T16:13:25Z CONTRIBUTOR

I think _repr_*_ is the standard from IPython/Jupyter (https://ipython.readthedocs.io/en/stable/config/integrating.html), so _repr_short_ or _repr_inline_ is just following along with that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726
669275077 https://github.com/pydata/xarray/pull/4248#issuecomment-669275077 https://api.github.com/repos/pydata/xarray/issues/4248 MDEyOklzc3VlQ29tbWVudDY2OTI3NTA3Nw== max-sixty 5635139 2020-08-05T15:55:32Z 2020-08-05T15:55:32Z MEMBER

Looks great to me.

I'm not sure the naming convention: is a single _ dunder standard? Or does that look like a private method?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow customizing the inline repr of a duck array 663825726

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);