issue_comments

Table actions

7 rows where issue = 536639533 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Pint support for top-level functions · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
596374671 https://github.com/pydata/xarray/pull/3611#issuecomment-596374671 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU5NjM3NDY3MQ== dcherian 2448579 2020-03-09T07:40:40Z 2020-03-09T07:40:40Z MEMBER

Yeah, thanks @keewis 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533
596027950 https://github.com/pydata/xarray/pull/3611#issuecomment-596027950 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU5NjAyNzk1MA== max-sixty 5635139 2020-03-07T01:23:53Z 2020-03-07T01:23:53Z MEMBER

Looks good! (as ever with me & this section of code, without being that confident)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533
596025596 https://github.com/pydata/xarray/pull/3611#issuecomment-596025596 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU5NjAyNTU5Ng== keewis 14808389 2020-03-07T01:06:47Z 2020-03-07T01:06:47Z MEMBER

This should be ready for review / merge once again.

It seems that after the merge of #3706 all that was left to get the top-level function tests to pass was to clean up those tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533
567275273 https://github.com/pydata/xarray/pull/3611#issuecomment-567275273 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU2NzI3NTI3Mw== keewis 14808389 2019-12-19T00:34:12Z 2019-12-19T00:34:12Z MEMBER

I added a whats-new.rst entry, but I'm not sure if it is too minimal.

If this is okay for now, we could merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533
565411716 https://github.com/pydata/xarray/pull/3611#issuecomment-565411716 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU2NTQxMTcxNg== max-sixty 5635139 2019-12-13T11:41:53Z 2019-12-13T11:41:53Z MEMBER

Thanks for the review @dcherian !

@keewis FYI I am starting a new job so will be lying low on xarray for a couple of months, forgive the temporary pause in speedy reviews. It was great to work together for the past few months!

The whole team is looking forward to working more closely with you in the future. We'd like to invite you to be a maintainer: could you drop me an email at m at maxroos period com?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533
564906552 https://github.com/pydata/xarray/pull/3611#issuecomment-564906552 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU2NDkwNjU1Mg== keewis 14808389 2019-12-12T08:40:20Z 2019-12-12T08:40:20Z MEMBER

the _getitem_with_mask failures are due to bool not defining __invert__, which means it falls back to int.__invert__. I special-cased it, but we could also modify indexing.create_mask to always return a duck array.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533
564757094 https://github.com/pydata/xarray/pull/3611#issuecomment-564757094 https://api.github.com/repos/pydata/xarray/issues/3611 MDEyOklzc3VlQ29tbWVudDU2NDc1NzA5NA== keewis 14808389 2019-12-11T22:13:11Z 2019-12-11T22:45:48Z MEMBER

it seems the changes to Variable._getitem_with_mask will make other tests fail. The reason for the changes is that pint will convert every argument of np.where to the first argument's units, which would convert the array to the fill value's units and would be quite unexpected, I think?. Does anyone know what to do here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for top-level functions 536639533

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);