issue_comments

Table actions

5 rows where issue = 520252049 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • make coarsen reductions consistent with reductions on other classes · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
561704512 https://github.com/pydata/xarray/pull/3500#issuecomment-561704512 https://api.github.com/repos/pydata/xarray/issues/3500 MDEyOklzc3VlQ29tbWVudDU2MTcwNDUxMg== dcherian 2448579 2019-12-04T15:48:22Z 2019-12-04T15:48:22Z MEMBER

In the case of multiple reduction axes i.e. isinstance(axis, tuple) is True we don't use the bottleneck method so things should be fine.

https://github.com/pydata/xarray/blob/ed05f9862622b00f40f7b9b99ccdb0ab3766ff0f/xarray/core/nputils.py#L210-L218

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make coarsen reductions consistent with reductions on other classes 520252049
555609814 https://github.com/pydata/xarray/pull/3500#issuecomment-555609814 https://api.github.com/repos/pydata/xarray/issues/3500 MDEyOklzc3VlQ29tbWVudDU1NTYwOTgxNA== dcherian 2448579 2019-11-19T17:11:19Z 2019-11-19T17:11:19Z MEMBER

Probably I wondered if bottleneck works with multiple reduction axes.

I'll check this before merging.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make coarsen reductions consistent with reductions on other classes 520252049
554753772 https://github.com/pydata/xarray/pull/3500#issuecomment-554753772 https://api.github.com/repos/pydata/xarray/issues/3500 MDEyOklzc3VlQ29tbWVudDU1NDc1Mzc3Mg== dcherian 2448579 2019-11-17T15:00:18Z 2019-11-17T15:00:18Z MEMBER

I don't remember why I added a separate injection function...

:+1:

Can you add some tests for coarsen.count() and skipna in the reduction methods?

There is a count test in test_variable. I've added sum(skipna=...) tests there too now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make coarsen reductions consistent with reductions on other classes 520252049
554647990 https://github.com/pydata/xarray/pull/3500#issuecomment-554647990 https://api.github.com/repos/pydata/xarray/issues/3500 MDEyOklzc3VlQ29tbWVudDU1NDY0Nzk5MA== dcherian 2448579 2019-11-16T15:38:47Z 2019-11-16T15:38:47Z MEMBER

@fujisoup this could use a review if you have time. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make coarsen reductions consistent with reductions on other classes 520252049
552065072 https://github.com/pydata/xarray/pull/3500#issuecomment-552065072 https://api.github.com/repos/pydata/xarray/issues/3500 MDEyOklzc3VlQ29tbWVudDU1MjA2NTA3Mg== max-sixty 5635139 2019-11-09T04:25:57Z 2019-11-09T04:25:57Z MEMBER

Great idea, there's lots of room to centralize some of these!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make coarsen reductions consistent with reductions on other classes 520252049

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);