issue_comments

Table actions

5 rows where issue = 439418506 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • plot: If provided with colormap do not modify it. · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
488546457 https://github.com/pydata/xarray/pull/2935#issuecomment-488546457 https://api.github.com/repos/pydata/xarray/issues/2935 MDEyOklzc3VlQ29tbWVudDQ4ODU0NjQ1Nw== pep8speaks 24736507 2019-05-02T04:00:46Z 2019-05-09T16:19:49Z NONE

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-05-09 16:19:49 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot: If provided with colormap do not modify it. 439418506
489743024 https://github.com/pydata/xarray/pull/2935#issuecomment-489743024 https://api.github.com/repos/pydata/xarray/issues/2935 MDEyOklzc3VlQ29tbWVudDQ4OTc0MzAyNA== dcherian 2448579 2019-05-06T19:22:46Z 2019-05-06T19:22:46Z MEMBER

Failed test is #2940. I'll merge in a few days if no one else has any comments

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot: If provided with colormap do not modify it. 439418506
488685394 https://github.com/pydata/xarray/pull/2935#issuecomment-488685394 https://api.github.com/repos/pydata/xarray/issues/2935 MDEyOklzc3VlQ29tbWVudDQ4ODY4NTM5NA== dcherian 2448579 2019-05-02T14:01:56Z 2019-05-02T14:01:56Z MEMBER

Never mind; should be all good now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot: If provided with colormap do not modify it. 439418506
488681464 https://github.com/pydata/xarray/pull/2935#issuecomment-488681464 https://api.github.com/repos/pydata/xarray/issues/2935 MDEyOklzc3VlQ29tbWVudDQ4ODY4MTQ2NA== dcherian 2448579 2019-05-02T13:51:32Z 2019-05-02T13:51:32Z MEMBER

:man_facepalming: Thanks @mathause. I was too sleepy I guess.

The example now works; but the test doesn't work. It should fail for cmap='RdBu_r' but doesn't locally. Any suggestions would be helpful

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot: If provided with colormap do not modify it. 439418506
488601719 https://github.com/pydata/xarray/pull/2935#issuecomment-488601719 https://api.github.com/repos/pydata/xarray/issues/2935 MDEyOklzc3VlQ29tbWVudDQ4ODYwMTcxOQ== mathause 10194086 2019-05-02T09:13:05Z 2019-05-02T09:13:05Z MEMBER

Thanks for the PR, however this did not work for the minimal example @lvankampenhout provided because isinstance(mpl.colors.ListedColormap, mpl.colors.Colormap) returns False (and you get a ListedColormap when specifying levels).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   plot: If provided with colormap do not modify it. 439418506

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);