issue_comments

Table actions

6 rows where issue = 230631480 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • xarray.core.variable.as_variable part of the public API · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
305865518 https://github.com/pydata/xarray/pull/1422#issuecomment-305865518 https://api.github.com/repos/pydata/xarray/issues/1422 MDEyOklzc3VlQ29tbWVudDMwNTg2NTUxOA== shoyer 1217238 2017-06-02T17:55:18Z 2017-06-02T17:55:18Z MEMBER

@benbovy thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.core.variable.as_variable part of the public API 230631480
303697667 https://github.com/pydata/xarray/pull/1422#issuecomment-303697667 https://api.github.com/repos/pydata/xarray/issues/1422 MDEyOklzc3VlQ29tbWVudDMwMzY5NzY2Nw== benbovy 4160723 2017-05-24T11:32:40Z 2017-05-24T11:32:40Z MEMBER

I've tried adding tests for lines in as_variable that were not yet covered.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.core.variable.as_variable part of the public API 230631480
303635426 https://github.com/pydata/xarray/pull/1422#issuecomment-303635426 https://api.github.com/repos/pydata/xarray/issues/1422 MDEyOklzc3VlQ29tbWVudDMwMzYzNTQyNg== shoyer 1217238 2017-05-24T06:57:57Z 2017-05-24T06:57:57Z MEMBER

We have some tests for as_variable, but it looks a little thin for public API: https://github.com/pydata/xarray/blob/d80248476ebe4a3845211c5d58e0af1effc73ea3/xarray/tests/test_variable.py#L609

The remaining test failures should be fixed by https://github.com/pydata/xarray/pull/1423

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.core.variable.as_variable part of the public API 230631480
303513756 https://github.com/pydata/xarray/pull/1422#issuecomment-303513756 https://api.github.com/repos/pydata/xarray/issues/1422 MDEyOklzc3VlQ29tbWVudDMwMzUxMzc1Ng== shoyer 1217238 2017-05-23T19:56:21Z 2017-05-23T19:56:21Z MEMBER

Mmm I don't see any current use of the copy keyword argument inside the as_variable function. Here is the only place where I found copy to be explicitly provided. Can I safely remove it also there?

Yes, we can safely remove the copy argument here. At point point, as_variable did not always return a new Variable object, but as you can see it always does that now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.core.variable.as_variable part of the public API 230631480
303378994 https://github.com/pydata/xarray/pull/1422#issuecomment-303378994 https://api.github.com/repos/pydata/xarray/issues/1422 MDEyOklzc3VlQ29tbWVudDMwMzM3ODk5NA== benbovy 4160723 2017-05-23T12:13:56Z 2017-05-23T12:13:56Z MEMBER

Oh yes I haven't run the tests locally before submitting this, I didn't expected that.

Mmm I don't see any current use of the copy keyword argument inside the as_variable function. Here is the only place where I found copy to be explicitly provided. Can I safely remove it also there? If I remove it the tests pass again (although I got 3 remaining failing tests that don't seem to be related to this issue as they fail either with or without the copy argument).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.core.variable.as_variable part of the public API 230631480
303371875 https://github.com/pydata/xarray/pull/1422#issuecomment-303371875 https://api.github.com/repos/pydata/xarray/issues/1422 MDEyOklzc3VlQ29tbWVudDMwMzM3MTg3NQ== fmaussion 10050469 2017-05-23T11:39:36Z 2017-05-23T11:39:36Z MEMBER

Many tests fail because they expect to have a copy= kwarg somehow...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray.core.variable.as_variable part of the public API 230631480

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);