issue_comments

Table actions

3 rows where issue = 1358247997 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Ensure encoding["source"] is available for a pathlib.Path object · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1450715249 https://github.com/pydata/xarray/pull/6974#issuecomment-1450715249 https://api.github.com/repos/pydata/xarray/issues/6974 IC_kwDOAMm_X85WeChx kwodzicki 19718721 2023-03-01T19:12:12Z 2023-03-01T19:12:12Z NONE

It would be great to further improve this by handling file-like objects. I am running into an issue when trying to read some data from S3 buckets. I can pass in a file-like object and read the data, but there is no .encoding['source'] in the subsequent dataset.

Can simulate this 'issue' using local data:

import xarray as xr
file = '/path/to/file.nc'
fid  = open(file, 'rb')
ds   = xr.open_dataset( fid, engine='h5netcdf' )

This will have no source encoding in the dataset, but it could be grabbed from fid.name.

Could a check be added for file-like objects, and then insert the .path or .name attribute into .encoding['source']?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensure encoding["source"] is available for a pathlib.Path object 1358247997
1244589007 https://github.com/pydata/xarray/pull/6974#issuecomment-1244589007 https://api.github.com/repos/pydata/xarray/issues/6974 IC_kwDOAMm_X85KLuvP mathause 10194086 2022-09-12T22:15:10Z 2022-09-12T22:15:10Z MEMBER

Let's see if that works now - should auto-merge on green.

Thanks for your contribution and welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensure encoding["source"] is available for a pathlib.Path object 1358247997
1242877683 https://github.com/pydata/xarray/pull/6974#issuecomment-1242877683 https://api.github.com/repos/pydata/xarray/issues/6974 IC_kwDOAMm_X85KFM7z ColemanTom 15375218 2022-09-11T03:32:21Z 2022-09-11T03:32:21Z CONTRIBUTOR

I think it's also possible to pass the whole dataset as bytes & we don't want this to end off in ds.encoding["source"] I hope my suggestion would take care of this.

Thanks. I had forgotten you could, for example, pass file-like objects as I don't tend to. I've confirmed your suggestion works and have added it to the change. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Ensure encoding["source"] is available for a pathlib.Path object 1358247997

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);